Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasm-compatible asserts in tests #3286

Open
Tracked by #3678
cwfitzgerald opened this issue Dec 11, 2022 · 0 comments
Open
Tracked by #3678

Use wasm-compatible asserts in tests #3286

cwfitzgerald opened this issue Dec 11, 2022 · 0 comments
Labels
api: gles Issues with GLES or WebGL area: tests Improvements or issues with our test suite help required We need community help to make this happen. type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

Because we want to have expected-to-fail tests (due to driver bugs or internal bugs), we want all tests to be recoverable, even on wasm. Currently we achieve this by catching panics from various assertions. However, because wasm doesn't support stack unwinding, we can't do this.

We should switch to assert calls that bail out of the test either through early returns, or no returns at all. This way we can properly recover after errors on wasm as well.

@cwfitzgerald cwfitzgerald added api: gles Issues with GLES or WebGL area: tests Improvements or issues with our test suite type: enhancement New feature or request help required We need community help to make this happen. labels Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: gles Issues with GLES or WebGL area: tests Improvements or issues with our test suite help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant