Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Push Constants for DX12 #2829

Closed
Tracked by #2719
cwfitzgerald opened this issue Jul 1, 2022 · 4 comments · Fixed by #2866
Closed
Tracked by #2719

Implement Push Constants for DX12 #2829

cwfitzgerald opened this issue Jul 1, 2022 · 4 comments · Fixed by #2866
Labels
api: dx12 Issues with DX12 or DXGI area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Jul 1, 2022 •
edited
Loading

We currently cannot combine user defined push constants with the existing root constants that naga sends forward. This is partly a wgpu and partly a naga task.
@cwfitzgerald cwfitzgerald mentioned this issue Jul 1, 2022
Open
15 tasks
@cwfitzgerald cwfitzgerald added type: enhancement New feature or request help required We need community help to make this happen. area: api Issues related to API surface api: dx12 Issues with DX12 or DXGI labels Jul 1, 2022
@memoryruins
Copy link
Contributor

naga's tracking issue for implementing push constants for its HLSL backend gfx-rs/naga#1782

@LoganDark
Copy link

Looks like that issue has been resolved now

@cwfitzgerald
Copy link
Member Author

Still waiting on #2866

@LoganDark
Copy link

LoganDark commented Sep 3, 2022 •
edited
Loading

Might want to add a closing keyword to that PR, then

@cwfitzgerald cwfitzgerald mentioned this issue Sep 4, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: dx12 Issues with DX12 or DXGI area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dx12: Add support for push constants JCapucho/wgpu
3 participants
@LoganDark @memoryruins @cwfitzgerald