Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline overrides #1762

Closed
kvark opened this issue Aug 3, 2021 · 6 comments · Fixed by #5500
Closed

Pipeline overrides #1762

kvark opened this issue Aug 3, 2021 · 6 comments · Fixed by #5500
Labels
area: api Issues related to API surface type: enhancement New feature or request
Milestone
WebGPU Specificat...

Comments

@kvark
Copy link
Member

kvark commented Aug 3, 2021

Is your feature request related to a problem? Please describe.
See gpuweb/gpuweb#886

Describe the solution you'd like
Just follow the spec

Describe alternatives you've considered
?

Additional context
@kvark kvark added type: enhancement New feature or request area: api Issues related to API surface labels Aug 3, 2021
@kvark kvark added this to the Release 0.11 milestone Sep 27, 2021
@kvark
Copy link
Member Author

kvark commented Sep 27, 2021

Adding a milestone tentatively, let's see how difficult this is going to be.

@kvark kvark mentioned this issue Oct 25, 2023
Closed
@kvark kvark removed this from the Release 0.11 milestone Oct 6, 2021
@kvark
Copy link
Member Author

kvark commented Oct 6, 2021

Too much work for this milestone, actually

@aloucks
Copy link
Contributor

aloucks commented Dec 25, 2021

Any update on this? It would be really nice to avoid string replacement on the shader source.

It looks like the syntax has changed since the linked PR:
https://gpuweb.github.io/gpuweb/#dictdef-gpuprogrammablestage

@kvark
Copy link
Member Author

kvark commented Dec 25, 2021

Yep, that's why I'm not in a rush. The topic has been actively discussed recently. I think the main approach is figured out now, and just some details are missing.

@adeline-sparks
Copy link
Contributor

I'd really like to use this too! Do you think the spec is stable enough to implement it? I have some free time upcoming and might give it a try if so.

@teoxoy
Copy link
Member

teoxoy commented Nov 24, 2022 •
edited
Loading

@adeline-sparks I'm implementing this in naga. Will put up a PR for wgpu as well later when I got things sorted out in naga.

@teoxoy teoxoy self-assigned this Nov 24, 2022
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 5, 2022
@teoxoy teoxoy mentioned this issue Oct 25, 2023
Open
@Wumpf Wumpf mentioned this issue Jun 29, 2023
Closed
@jimblandy jimblandy mentioned this issue Mar 25, 2024
Merged
@teoxoy teoxoy mentioned this issue Apr 5, 2024
Merged
@teoxoy teoxoy removed their assignment Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface type: enhancement New feature or request
Projects
WebGPU for Firefox
Status: Done
Milestone
WebGPU Specification V1
Development

Successfully merging a pull request may close this issue.

Pipeline constants gfx-rs/wgpu
4 participants
@kvark @aloucks @teoxoy @adeline-sparks