This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Implement PUSH_CONSTANTS feature #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
push-constants
branch
from
1fea6fe to
801ef56
Compare
cwfitzgerald
force-pushed
the
push-constants
branch
2 times, most recently
from
d3f8f60 to
be75abe
Compare
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jul 13, 2020
777: Implement PUSH_CONSTANTS feature r=kvark a=cwfitzgerald **Connections** Closes #734. Makes minor progress on #689. **Description** This one is a doozy. Implements Push Constant support in wgpu. Implementation Notes: - Push constants are unconditionally cleared on change to a pipeline with a different pipeline layout. This could be elided in a future revision, possibly making push constants slightly faster on non-vulkan platforms. - This exposes basically a direct port of vulkan push constants to wgpu. There might be design decisions that would want to be changed for an upstream webgpu implementation. Code Notes: - The render bundle code needs to be heavily scrutinized because I wasn't able to test it and it requires pipeline invalidation. - Validation should be correct as I have tested it pretty throughly, but there are a lot of factors involved, so I could have accidentally missed something (or not allowed something I should have). Other Work: - `PipelineLayoutDescriptor` was moved into wgt from wgpu-rs with a generic. **Testing** I have modified the wgpu-rs example to use push constants for its uniform fallback, which is a perfect use case for push constants. I have not tested compute constants, but I expect no issues with them. gfx-rs/wgpu-rs#435 Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
cwfitzgerald
force-pushed
the
push-constants
branch
from
be75abe to
992bf5d
Compare
|
Should be ready for review. |
cwfitzgerald
force-pushed
the
push-constants
branch
from
992bf5d to
dde345d
Compare
cwfitzgerald
force-pushed
the
push-constants
branch
from
dde345d to
a670472
Compare
|
Rebased and fixed a warning on wasm that has been bugging me for the last 2 months. |
|
bors r- |
|
Canceled. |
|
bors r=kvark |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust half of the push constant extensions, continuing from gfx-rs/wgpu#777.