Support fail on request/response violation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboos
changed the title
pboos
commented
May 24, 2023
| import reactor.core.publisher.Mono; | ||
| import reactor.test.StepVerifier; | ||
|
|
||
| class OpenApiValidationWebFilterTest { |
There was a problem hiding this comment.
ℹ️ Very similar to the other test. Same approach used. Differences are mainly the mocking.
pboos
commented
May 24, 2023
|
|
||
| @Override | ||
| public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException { | ||
| public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) |
There was a problem hiding this comment.
ℹ️ Changes here are copy paste from the non spring 2.7.
Different imports and/or minimal code changes like HttpStatus vs HttpStatusCode which changed in spring boot .
pboos
commented
May 24, 2023
| @@ -48,31 +51,107 @@ private Mono<Void> decorateWithValidation(ServerWebExchange exchange, WebFilterC | |||
|
|
|||
| var serverWebExchange = exchange.mutate().request(requestDecorated).response(responseDecorated).build(); | |||
|
|
|||
| var alreadyDidRequestValidation = validateRequestWithFailOnViolation(requestMetaData, requestDecorated); | |||
There was a problem hiding this comment.
ℹ️ Changes here are copy paste from the non spring 2.7.
Different imports and/or minimal code changes like HttpStatus vs HttpStatusCode which changed in spring boot .
ursulean
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for failing the request on violations.
In case of a request violation it will not execute the endpoint logic at all.
Configuration in
application.propertieswithNote for reviewing: The WebFilter and HttpFilter in spring 2.7 modules are copy paste from the spring 3.0 ones with just the changes needed for spring 2.7 (different imports due to different package or class name).