[Task] DEP-412: RN 2.0.0 #34
Conversation
|
All major flows verified. |
|
|
||
| # Android/IJ | ||
| # | ||
| .idea |
There was a problem hiding this comment.
You could add a few more items for Android, such as bin/, gen/, etc. Let's take this offline and I can send you what we have set up internally for the native SDK.
| @@ -1,21 +0,0 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
Nevermind, saw the updates to the README in the next commit 👍
There was a problem hiding this comment.
because the licence is specified via url in the readme
README.md
Outdated
| [](https://github.com/getyoti/yoti-doc-scan-react-native/releases) [](https://github.com/getyoti/yoti-doc-scan-react-native/actions?query=workflow%3A%22Publish+Release%22) | ||
|
|
||
| Yoti is an identity checking platform that allows organisations to verify who people are, online and in person. The Yoti Doc Scan SDK allows the user to take a photo of their identifying document which we verify instantly and prepare a response which your system can then retrieve. Further information can be found in the [documentation](https://developers.yoti.com/yoti/getting-started-docscan). | ||
| A react native wrapper of Yoti IDV for [Android](https://github.com/getyoti/yoti-doc-scan-android) and [iOS](https://github.com/getyoti/yoti-doc-scan-ios). Yoti IDV allows a user of your app to take a photo of their document, as well as to scan or capture their face, we then verify this instantly and prepare a response, which your system can then retrieve on your hosted site.s |
| @@ -101,162 +57,105 @@ If you're using **Proguard** or other obfuscation tool, add the following config | |||
| -dontwarn javax.annotation.Nullable | |||
| ``` | |||
|
|
|||
|
|
|||
| Depending on your Android project setup and version of React Native, you | |||
There was a problem hiding this comment.
Why were these troubleshooting steps removed?
There was a problem hiding this comment.
because those steps are about general errors that can occur, and have nothing to do with our sdk specifically
| "start": "react-native start" | ||
| }, | ||
| "dependencies": { | ||
| "react": "^17.0.2", |
There was a problem hiding this comment.
I'm not a big fan of version ranges, since they might introduce changes we might not want/anticipate. 🤔
There was a problem hiding this comment.
the range includes minors + patches. not majors, so it's fine
example/README.md
Outdated
| - Open the `ios/example.xcworkspace` file with XCode | ||
| - Run a build as you regularly would, preferrably on a device with the Yoti app installed | ||
| ### Android | ||
| To continue your installation with Android, you should run `yarn start` and `adb -s DEVICE_ID_HERE reverse tcp:8081 tcp:8081` (or `adb reverse tcp:8081 tcp:8081` if using a simulator) from the `example` directory. , and then open the `example/android` project in Android Studio. You can now sync Gradle and build the app. |
There was a problem hiding this comment.
A bit nitpicking here, but on Android it's "emulator" 😄
| - If you are running on a physical device, remember to execute `adb -s DEVICE_ID_HERE reverse tcp:8081 tcp:8081`. You can find the appropriate device id by running `adb devices` | ||
|
|
||
| # Android (using React Native CLI) | ||
| - Simply execute `yarn run android` in the `example` folder |
There was a problem hiding this comment.
This section is useful, it's way easier to simply run the app like this, I would not remove it.
There was a problem hiding this comment.
wasn't removed. just moved.
| versionCode 110 | ||
| versionName "1.1.0" | ||
| versionCode 1 | ||
| versionName "1.0.0" |
There was a problem hiding this comment.
I know that given this is an example app, it probably does not matter, but when downgrading versionCode and attempting to run (basically update) an app, you'd get an error saying you are attempting to install an older version and asking you to uninstall the previous newer one first.
Again, might not matter since this would never get published, but still thought I'd mention this.
| @@ -192,7 +76,12 @@ android { | |||
|
|
|||
| dependencies { | |||
| implementation fileTree(dir: "libs", include: ["*.jar"]) | |||
| implementation "com.facebook.react:react-native:0.68.5" // From node_modules | |||
| implementation "com.facebook.react:react-native:0.68.5" | |||
| implementation "com.yoti.mobile.android.sdk:yoti-sdk-doc-scan:${rootProject.ext.yotiSdkVersion}" | |||
There was a problem hiding this comment.
Before we included all module deps, I'm wondering if we should change that now...
There was a problem hiding this comment.
using id docs + liveness as default
There was a problem hiding this comment.
But liveness is commented below
There was a problem hiding this comment.
You're right, sorry, scrolled past it
asklausen
force-pushed
the
release/DEP-398-2.0.0
branch
from
a04d396
to
8d532e8
Compare
Purpose
External References (e.g. Jira / Zeplin / Confluence)
DEP-412