Skip to content

fix(eslint): Cleanup some TS cruft in the eslint.config.mjs file #83468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(eslint): Cleanup some TS cruft in the eslint.config.mjs file #83468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import {builtinModules} from 'node:module';
import typescript from 'typescript-eslint';

invariant(react.configs.flat, 'For typescript');
invariant(react.configs.flat.recommended, 'For typescript');
invariant(react.configs.flat['jsx-runtime'], 'For typescript');

const restrictedImportPatterns = [
{
Expand Down Expand Up @@ -262,7 +264,7 @@ export default typescript.config([
'no-sequences': 'error',
'no-throw-literal': 'error',
'object-shorthand': ['error', 'properties'],
'require-await': 'error', // TODO: see also @typescript-eslint/require-await
'require-await': 'error', // Enabled in favor of @typescript-eslint/require-await, which requires type info
'spaced-comment': [
'error',
'always',
Expand Down Expand Up @@ -316,8 +318,7 @@ export default typescript.config([
name: 'plugin/react',
// https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules
plugins: {
...(react.configs.flat.recommended?.plugins ?? {}),
// @ts-ignore noUncheckedIndexedAccess
...react.configs.flat.recommended.plugins,
...react.configs.flat['jsx-runtime'].plugins,
},
rules: {
Expand All @@ -333,8 +334,7 @@ export default typescript.config([
'react/sort-comp': 'error',

// https://github.com/jsx-eslint/eslint-plugin-react/blob/master/index.js
...(react.configs.flat.recommended?.rules ?? {}),
// @ts-ignore noUncheckedIndexedAccess
...react.configs.flat.recommended.rules,
...react.configs.flat['jsx-runtime'].rules,
'react/display-name': 'off', // TODO(ryan953): Fix violations and delete this line
'react/no-unescaped-entities': 'off', // TODO(ryan953): Fix violations and delete this line
Expand All @@ -358,7 +358,7 @@ export default typescript.config([
name: 'plugin/typescript-eslint/custom',
rules: {
'no-shadow': 'off', // Disabled in favor of @typescript-eslint/no-shadow
'no-use-before-define': 'off',
'no-use-before-define': 'off', // See also @typescript-eslint/no-use-before-define

'@typescript-eslint/naming-convention': [
'error',
Expand Down Expand Up @@ -387,7 +387,7 @@ export default typescript.config([
},
],
'@typescript-eslint/no-shadow': 'error',
'@typescript-eslint/no-use-before-define': 'off', // TODO(ryan953): Configure this and enable it
'@typescript-eslint/no-use-before-define': 'off', // Enabling this will cause a lot of thrash to the git history
},
},
// https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/base.ts
Expand Down
Loading