ref: fix types for EventUser #72897
Merged
ref: fix types for EventUser #72897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
asottile-sentry
commented
Jun 17, 2024
| @@ -117,7 +118,7 @@ def get_display_name(self): | |||
| @classmethod | |||
| def for_projects( | |||
| self, | |||
| projects: list[Project], | |||
| projects: QuerySet[Project] | list[Project], | |||
There was a problem hiding this comment.
this is kind of a gross union -- but tests call this with a list so it'd be annoying to fix those (it can't be Sequence because a QuerySet isn't one, it can't be Iterable because accesses are done using indices!)
IanWoodard
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.