feat(replays): add initial replay cards to replay list #53323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
reviewed
Jul 21, 2023
ryan953
reviewed
Jul 21, 2023
ryan953
reviewed
Jul 21, 2023
Comment on lines
+138
to
+142
| const SplitCardContainer = styled('div')` | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: ${space(2)}; | ||
| `; |
There was a problem hiding this comment.
Grid! looks so easy once it's working!
static/app/views/replays/list/replaysErroneousDeadRageCards.tsx
Outdated
Show resolved
Hide resolved
ryan953
approved these changes
Jul 21, 2023
ryan953
reviewed
Jul 21, 2023
| fetchError={fetchError} | ||
| isFetching={isFetching} | ||
| replays={replays?.slice(0, 3)} | ||
| sort={eventView.sorts[0]} |
There was a problem hiding this comment.
what if this was sort={undefined}
ryan953
reviewed
Jul 21, 2023
michellewzhang
force-pushed
the
mz/add-replay-cards
branch
from
b8e26ab
to
01b612b
Compare
armenzg
pushed a commit
that referenced
this pull request
Jul 24, 2023
closes #53086 created two experimental tables on the replay list page: 1. top 3 most erroneous replays within the last 7 days 2. top 3 most dead click replays within the last 7 days (can change these time periods, I just thought 1 day was too little time for a useful sample size since a lot of numbers showed 0) notes: - these tables are static when compared to the big replay list table, so pagination doesn't affect them (see below for screenshots showing this) - in theory, rage clicks always < dead clicks, which is why I chose to sort by dead clicks page 1: <img width="1250" alt="SCR-20230721-jybf" src="https://github.com/getsentry/sentry/assets/56095982/1c2f6981-e504-4d90-9f88-4c4dfc4523f5"> page 2 (same tables, different replays on big list): <img width="1238" alt="SCR-20230721-jxge" src="https://github.com/getsentry/sentry/assets/56095982/d4b231e3-8786-4144-8122-cc57af0ef3ca">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53086
created two experimental tables on the replay list page:
(can change these time periods, I just thought 1 day was too little time for a useful sample size since a lot of numbers showed 0)
notes:
page 1:
page 2 (same tables, different replays on big list):
