ref(ts): Convert formatters.jsx to TypeScript #14302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Aug 7, 2019
|
|
||
| export function userDisplayName(user) { | ||
| export function userDisplayName(user: User): string { |
There was a problem hiding this comment.
On line 7 this function uses get(user, 'name', ...) implying that email is an optional property. Should the type reflect that?
There was a problem hiding this comment.
Good point. Looking back at #13707, I see why this is the case now. I think I'll add a CommitAuthor type and type user as User | CommitAuthor so that we can keep the stricter typing for users.
There was a problem hiding this comment.
Updated, thanks for catching that!
markstory
approved these changes
Aug 7, 2019
Add the User type
lynnagara
force-pushed
the
ts/formatters
branch
from
087f6d3 to
cd9c5c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the User type