Skip to content

Commit e803b2a

Browse files
authored
fix: Update symbolicator snapshots (#12710)
* fix: Update symbolicator snapshots * feat: Add warnings and comments for running symbolicator on mac * fix: Add debug_meta and images to all snapshots * fix: Make host.docker.internal just the default for OSX, remove warning from devservices * fix: Broken import * fix: Do not use DEBUG flag * fix: Add contexts to snapshots * fix: Update snapshots * fix: Add errors
1 parent 3d37927 commit e803b2a

File tree

8 files changed

+51
-242
lines changed

8 files changed

+51
-242
lines changed

src/sentry/lang/native/symbolicator.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from __future__ import absolute_import
22

3+
import sys
34
import jsonschema
45
import logging
56
import six
@@ -104,8 +105,13 @@ def get_internal_source(project):
104105
"""
105106
Returns the source configuration for a Sentry project.
106107
"""
107-
internal_url_prefix = options.get('system.internal-url-prefix') \
108-
or options.get('system.url-prefix')
108+
internal_url_prefix = options.get('system.internal-url-prefix')
109+
if not internal_url_prefix:
110+
internal_url_prefix = options.get('system.url-prefix')
111+
if sys.platform == 'darwin':
112+
internal_url_prefix = internal_url_prefix \
113+
.replace("localhost", "host.docker.internal") \
114+
.replace("127.0.0.1", "host.docker.internal")
109115

110116
assert internal_url_prefix
111117
sentry_source_url = '%s%s' % (
Lines changed: 3 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
created: '2019-04-02T14:12:16.040240Z'
2+
created: '2019-04-15T09:43:14.321187Z'
33
creator: sentry
44
source: tests/symbolicator/test_native_plugin.py
55
---
@@ -12,7 +12,6 @@ contexts:
1212
name: Windows
1313
type: os
1414
version: 10.0.14393
15-
culprit: main
1615
debug_meta:
1716
images:
1817
- code_file: C:\projects\breakpad-tools\windows\Release\crash.exe
@@ -40,36 +39,5 @@ exception:
4039
thread_id: 1636
4140
type: EXCEPTION_ACCESS_VIOLATION_WRITE
4241
value: 'Fatal Error: EXCEPTION_ACCESS_VIOLATION_WRITE'
43-
fingerprint:
44-
- '{{ default }}'
45-
grouping_config:
46-
id: legacy:2019-03-12
47-
hashes:
48-
- ffe48bfc93b1bf86ffb750d5d2bdc51a
49-
level: error
50-
location: main.cpp
51-
logger: ''
52-
metadata:
53-
filename: main.cpp
54-
function: main
55-
type: EXCEPTION_ACCESS_VIOLATION_WRITE
56-
value: 'Fatal Error: EXCEPTION_ACCESS_VIOLATION_WRITE'
57-
platform: native
58-
sdk:
59-
name: _postWithHeader
60-
version: 0.0.0
61-
tags:
62-
- - level
63-
- error
64-
- - sentry:user
65-
- ip:127.0.0.1
66-
- - os
67-
- Windows 10.0.14393
68-
- - os.name
69-
- Windows
70-
title: 'EXCEPTION_ACCESS_VIOLATION_WRITE: Fatal Error: EXCEPTION_ACCESS_VIOLATION_WRITE'
71-
type: error
72-
use_rust_normalize: true
73-
user:
74-
ip_address: 127.0.0.1
75-
version: '6'
42+
stacktrace: null
43+
threads: null
Lines changed: 4 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
---
2-
created: '2019-04-02T14:12:16.775814Z'
2+
created: '2019-04-15T09:43:15.116901Z'
33
creator: sentry
44
source: tests/symbolicator/test_native_plugin.py
55
---
6-
culprit: unknown
6+
contexts: null
77
debug_meta:
88
images:
99
- arch: x86_64
@@ -18,12 +18,6 @@ debug_meta:
1818
version_major: 10
1919
version_minor: 12
2020
version_patchlevel: 4
21-
errors:
22-
- image_arch: x86_64
23-
image_path: Foo.app/Contents/Foo
24-
image_uuid: 502fc0a5-1ec1-3e47-9998-684fa139dca7
25-
message: None
26-
type: native_missing_dsym
2721
exception:
2822
values:
2923
- raw_stacktrace:
@@ -37,41 +31,5 @@ exception:
3731
- *id001
3832
type: Fail
3933
value: fail
40-
fingerprint:
41-
- '{{ default }}'
42-
grouping_config:
43-
id: legacy:2019-03-12
44-
hashes:
45-
- efca000ff6704f25e5434e9ed7eff02f
46-
level: error
47-
location: null
48-
logger: ''
49-
metadata:
50-
type: Fail
51-
value: fail
52-
platform: cocoa
53-
processing_issues:
54-
native:dsym:502fc0a5-1ec1-3e47-9998-684fa139dca7:
55-
data:
56-
image_arch: x86_64
57-
image_path: Foo.app/Contents/Foo
58-
image_uuid: 502fc0a5-1ec1-3e47-9998-684fa139dca7
59-
message: None
60-
type: native_missing_dsym
61-
object: dsym:502fc0a5-1ec1-3e47-9998-684fa139dca7
62-
scope: native
63-
type: native_missing_dsym
64-
sdk:
65-
name: _postWithHeader
66-
version: 0.0.0
67-
tags:
68-
- - level
69-
- error
70-
- - sentry:user
71-
- ip:127.0.0.1
72-
title: 'Fail: fail'
73-
type: error
74-
use_rust_normalize: true
75-
user:
76-
ip_address: 127.0.0.1
77-
version: '6'
34+
stacktrace: null
35+
threads: null
Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
---
2-
created: '2019-04-02T14:12:17.205926Z'
2+
created: '2019-04-15T09:43:15.764548Z'
33
creator: sentry
44
source: tests/symbolicator/test_native_plugin.py
55
---
6-
culprit: main
6+
contexts: null
77
debug_meta:
88
images:
99
- arch: x86_64
@@ -36,32 +36,5 @@ exception:
3636
package: Foo.app/Contents/Foo
3737
type: Fail
3838
value: fail
39-
fingerprint:
40-
- '{{ default }}'
41-
grouping_config:
42-
id: legacy:2019-03-12
43-
hashes:
44-
- 6e2889ec15f82569f56fdba9ffc9b90b
45-
level: error
46-
location: hello.c
47-
logger: ''
48-
metadata:
49-
filename: hello.c
50-
function: main
51-
type: Fail
52-
value: fail
53-
platform: cocoa
54-
sdk:
55-
name: _postWithHeader
56-
version: 0.0.0
57-
tags:
58-
- - level
59-
- error
60-
- - sentry:user
61-
- ip:127.0.0.1
62-
title: 'Fail: fail'
63-
type: error
64-
use_rust_normalize: true
65-
user:
66-
ip_address: 127.0.0.1
67-
version: '6'
39+
stacktrace: null
40+
threads: null
Lines changed: 4 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
created: '2019-04-08T15:19:10.243455Z'
2+
created: '2019-04-15T11:04:01.534478Z'
33
creator: sentry
44
source: tests/symbolicator/test_native_plugin.py
55
---
@@ -12,7 +12,6 @@ contexts:
1212
name: Windows
1313
type: os
1414
version: 10.0.14393
15-
culprit: main
1615
debug_meta:
1716
images:
1817
- arch: x86
@@ -21,6 +20,7 @@ debug_meta:
2120
image_addr: '0x2a0000'
2221
image_size: 36864
2322
type: symbolic
23+
errors: null
2424
exception:
2525
values:
2626
- raw_stacktrace:
@@ -42,36 +42,5 @@ exception:
4242
thread_id: 1636
4343
type: EXCEPTION_ACCESS_VIOLATION_WRITE
4444
value: 'Fatal Error: EXCEPTION_ACCESS_VIOLATION_WRITE'
45-
fingerprint:
46-
- '{{ default }}'
47-
grouping_config:
48-
id: legacy:2019-03-12
49-
hashes:
50-
- ffe48bfc93b1bf86ffb750d5d2bdc51a
51-
level: error
52-
location: main.cpp
53-
logger: ''
54-
metadata:
55-
filename: main.cpp
56-
function: main
57-
type: EXCEPTION_ACCESS_VIOLATION_WRITE
58-
value: 'Fatal Error: EXCEPTION_ACCESS_VIOLATION_WRITE'
59-
platform: native
60-
sdk:
61-
name: _postWithHeader
62-
version: 0.0.0
63-
tags:
64-
- - level
65-
- error
66-
- - sentry:user
67-
- ip:127.0.0.1
68-
- - os
69-
- Windows 10.0.14393
70-
- - os.name
71-
- Windows
72-
title: 'EXCEPTION_ACCESS_VIOLATION_WRITE: Fatal Error: EXCEPTION_ACCESS_VIOLATION_WRITE'
73-
type: error
74-
use_rust_normalize: true
75-
user:
76-
ip_address: 127.0.0.1
77-
version: '6'
45+
stacktrace: null
46+
threads: null
Lines changed: 4 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
---
2-
created: '2019-04-08T15:19:12.541376Z'
2+
created: '2019-04-15T11:04:03.933068Z'
33
creator: sentry
44
source: tests/symbolicator/test_native_plugin.py
55
---
6-
culprit: unknown
6+
contexts: null
77
debug_meta:
88
images:
99
- arch: x86_64
@@ -38,41 +38,5 @@ exception:
3838
instruction_addr: '0x100000fa0'
3939
type: Fail
4040
value: fail
41-
fingerprint:
42-
- '{{ default }}'
43-
grouping_config:
44-
id: legacy:2019-03-12
45-
hashes:
46-
- efca000ff6704f25e5434e9ed7eff02f
47-
level: error
48-
location: null
49-
logger: ''
50-
metadata:
51-
type: Fail
52-
value: fail
53-
platform: cocoa
54-
processing_issues:
55-
native:dsym:502fc0a5-1ec1-3e47-9998-684fa139dca7:
56-
data:
57-
image_arch: x86_64
58-
image_path: Foo.app/Contents/Foo
59-
image_uuid: 502fc0a5-1ec1-3e47-9998-684fa139dca7
60-
message: None
61-
type: native_missing_dsym
62-
object: dsym:502fc0a5-1ec1-3e47-9998-684fa139dca7
63-
scope: native
64-
type: native_missing_dsym
65-
sdk:
66-
name: _postWithHeader
67-
version: 0.0.0
68-
tags:
69-
- - level
70-
- error
71-
- - sentry:user
72-
- ip:127.0.0.1
73-
title: 'Fail: fail'
74-
type: error
75-
use_rust_normalize: true
76-
user:
77-
ip_address: 127.0.0.1
78-
version: '6'
41+
stacktrace: null
42+
threads: null
Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
---
2-
created: '2019-04-08T15:19:14.494425Z'
2+
created: '2019-04-15T11:04:06.116525Z'
33
creator: sentry
44
source: tests/symbolicator/test_native_plugin.py
55
---
6-
culprit: main
6+
contexts: null
77
debug_meta:
88
images:
99
- arch: x86_64
@@ -18,6 +18,7 @@ debug_meta:
1818
version_major: 10
1919
version_minor: 12
2020
version_patchlevel: 4
21+
errors: null
2122
exception:
2223
values:
2324
- raw_stacktrace:
@@ -37,32 +38,5 @@ exception:
3738
symbol: main
3839
type: Fail
3940
value: fail
40-
fingerprint:
41-
- '{{ default }}'
42-
grouping_config:
43-
id: legacy:2019-03-12
44-
hashes:
45-
- 6e2889ec15f82569f56fdba9ffc9b90b
46-
level: error
47-
location: hello.c
48-
logger: ''
49-
metadata:
50-
filename: hello.c
51-
function: main
52-
type: Fail
53-
value: fail
54-
platform: cocoa
55-
sdk:
56-
name: _postWithHeader
57-
version: 0.0.0
58-
tags:
59-
- - level
60-
- error
61-
- - sentry:user
62-
- ip:127.0.0.1
63-
title: 'Fail: fail'
64-
type: error
65-
use_rust_normalize: true
66-
user:
67-
ip_address: 127.0.0.1
68-
version: '6'
41+
stacktrace: null
42+
threads: null

0 commit comments

Comments
 (0)