Skip to content

Commit c624702

Browse files
authored
feat(events-v2): Match existing events ordering criteria (#13545)
Events with the same timestamp are sorted in order of event id
1 parent 162b88d commit c624702

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/sentry/static/sentry/app/sentryTypes.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export const EventView = PropTypes.shape({
117117
data: PropTypes.shape({
118118
fields: PropTypes.arrayOf(PropTypes.string),
119119
groupby: PropTypes.arrayOf(PropTypes.string),
120-
sort: PropTypes.string,
120+
orderby: PropTypes.arrayOf(PropTypes.string),
121121
}).isRequired,
122122
tags: PropTypes.arrayOf(PropTypes.string).isRequired,
123123
});

src/sentry/static/sentry/app/views/organizationEventsV2/data.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export const ALL_VIEWS = deepFreeze([
1818
name: 'All Events',
1919
data: {
2020
fields: ['event', 'type', 'project', 'user', 'time'],
21-
orderby: '-timestamp',
21+
orderby: ['-timestamp', '-id'],
2222
},
2323
tags: [
2424
'event.type',
@@ -35,7 +35,7 @@ export const ALL_VIEWS = deepFreeze([
3535
data: {
3636
fields: ['error', 'event_count', 'user_count', 'project', 'last_seen'],
3737
groupby: ['issue.id', 'project.id'],
38-
orderby: '-last_seen',
38+
orderby: ['-last_seen', '-issue.id'],
3939
},
4040
tags: ['error.type', 'project.name'],
4141
},
@@ -45,7 +45,7 @@ export const ALL_VIEWS = deepFreeze([
4545
data: {
4646
fields: ['csp', 'event_count', 'user_count', 'project', 'last_seen'],
4747
groupby: ['issue.id', 'project.id'],
48-
orderby: '-last_seen',
48+
orderby: ['-last_seen', '-issue.id'],
4949
},
5050
tags: [
5151
'project.name',

0 commit comments

Comments
 (0)