Skip to content

Commit af9f4d9

Browse files
authored
ref(sentry10): Clean up action creators (#13636)
Remove setting active environment by project as this is now handled by the global selection store.
1 parent 77ad480 commit af9f4d9

File tree

8 files changed

+0
-87
lines changed

8 files changed

+0
-87
lines changed

src/sentry/static/sentry/app/actionCreators/environments.jsx

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,4 @@
11
import EnvironmentActions from 'app/actions/environmentActions';
2-
import EnvironmentStore from 'app/stores/environmentStore';
3-
4-
export function setActiveEnvironment(environment) {
5-
EnvironmentActions.setActive(environment);
6-
}
7-
8-
export function setActiveEnvironmentName(name) {
9-
const environment = EnvironmentStore.getByName(name);
10-
11-
if (!environment) {
12-
return;
13-
}
14-
setActiveEnvironment(environment);
15-
}
16-
17-
export function clearActiveEnvironment() {
18-
EnvironmentActions.clearActive();
19-
}
202

213
export function loadEnvironments(data, envName) {
224
EnvironmentActions.loadData(data, envName);

src/sentry/static/sentry/app/actionCreators/projects.jsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,6 @@ import {t, tct} from 'app/locale';
99
import ProjectActions from 'app/actions/projectActions';
1010
import ProjectsStatsStore from 'app/stores/projectsStatsStore';
1111

12-
export function fetchProject(api, orgId, slug) {
13-
const promise = api.requestPromise(`/projects/${orgId}/${slug}/`, {method: 'GET'});
14-
promise.then(project => {
15-
ProjectActions.fetchSuccess(project);
16-
});
17-
18-
return promise;
19-
}
20-
2112
export function update(api, params) {
2213
ProjectActions.update(params.projectId, params.data);
2314

src/sentry/static/sentry/app/actionCreators/tags.jsx

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -60,23 +60,6 @@ function tagFetchSuccess(tags) {
6060
TagActions.loadTagsSuccess(trimmedTags);
6161
}
6262

63-
/**
64-
* Fetch tag values for a single project. Used for sentry9 views.
65-
*/
66-
export function fetchProjectTagValues(api, orgId, projectId, tagKey, search = null) {
67-
const url = `/projects/${orgId}/${projectId}/tags/${tagKey}/values/`;
68-
69-
const query = {};
70-
if (search) {
71-
query.query = search;
72-
}
73-
74-
return api.requestPromise(url, {
75-
method: 'GET',
76-
query,
77-
});
78-
}
79-
8063
/**
8164
* Fetch tags for an organization or a subset or projects.
8265
*/

src/sentry/static/sentry/app/actions/environmentActions.jsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import Reflux from 'reflux';
22

33
const EnvironmentActions = Reflux.createActions([
4-
'setActive',
5-
'clearActive',
64
'loadData',
75
'loadActiveData',
86
'loadHiddenData',

src/sentry/static/sentry/app/actions/projectActions.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import Reflux from 'reflux';
22

33
export default Reflux.createActions([
44
'createSuccess',
5-
'fetchSuccess',
65
'update',
76
'updateError',
87
'updateSuccess',

src/sentry/static/sentry/app/stores/environmentStore.jsx

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ import {toTitleCase} from 'app/utils';
44
import ProjectActions from 'app/actions/projectActions';
55
import EnvironmentActions from 'app/actions/environmentActions';
66

7-
import {setActiveEnvironment} from 'app/actionCreators/environments';
8-
import {ALL_ENVIRONMENTS_KEY} from 'app/constants';
9-
107
const DEFAULT_EMPTY_ENV_NAME = '(No Environment)';
118
const DEFAULT_EMPTY_ROUTING_NAME = 'none';
129

@@ -23,14 +20,6 @@ const EnvironmentStore = Reflux.createStore({
2320

2421
loadInitialData(items, activeEnvironmentName) {
2522
this.loadActiveData(items);
26-
// Update the default environment in the latest context store
27-
// The active environment will be null (aka All Environments) if the name matches
28-
// ALL_ENVIRONMENTS_KEY otherwise find the environment matching the name provided
29-
let activeEnvironment = null;
30-
if (activeEnvironmentName !== ALL_ENVIRONMENTS_KEY) {
31-
activeEnvironment = this.getByName(activeEnvironmentName) || this.getDefault();
32-
}
33-
setActiveEnvironment(activeEnvironment);
3423
},
3524

3625
loadHiddenData(items) {

src/sentry/static/sentry/app/stores/latestContextStore.jsx

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import Reflux from 'reflux';
22

33
import ProjectActions from 'app/actions/projectActions';
44
import OrganizationsActions from 'app/actions/organizationsActions';
5-
import EnvironmentActions from 'app/actions/environmentActions';
65
import NavigationActions from 'app/actions/navigationActions';
76

87
// Keeps track of last usable project/org
@@ -22,8 +21,6 @@ const LatestContextStore = Reflux.createStore({
2221
this.listenTo(ProjectActions.updateSuccess, this.onUpdateProject);
2322
this.listenTo(OrganizationsActions.setActive, this.onSetActiveOrganization);
2423
this.listenTo(OrganizationsActions.update, this.onUpdateOrganization);
25-
this.listenTo(EnvironmentActions.setActive, this.onSetActiveEnvironment);
26-
this.listenTo(EnvironmentActions.clearActive, this.onClearActiveEnvironment);
2724
this.listenTo(NavigationActions.setLastRoute, this.onSetLastRoute);
2825
},
2926

@@ -112,23 +109,6 @@ const LatestContextStore = Reflux.createStore({
112109
};
113110
this.trigger(this.state);
114111
},
115-
116-
onSetActiveEnvironment(environment) {
117-
this.state = {
118-
...this.state,
119-
environment,
120-
};
121-
122-
this.trigger(this.state);
123-
},
124-
125-
onClearActiveEnvironment() {
126-
this.state = {
127-
...this.state,
128-
environment: null,
129-
};
130-
this.trigger(this.state);
131-
},
132112
});
133113

134114
export default LatestContextStore;

src/sentry/static/sentry/app/stores/projectsStore.jsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const ProjectsStore = Reflux.createStore({
88
init() {
99
this.reset();
1010
this.listenTo(ProjectActions.createSuccess, this.onCreateSuccess);
11-
this.listenTo(ProjectActions.fetchSuccess, this.onFetchSuccess);
1211
this.listenTo(ProjectActions.updateSuccess, this.onUpdateSuccess);
1312
this.listenTo(ProjectActions.loadStatsSuccess, this.onStatsLoadSuccess);
1413
this.listenTo(ProjectActions.changeSlug, this.onChangeSlug);
@@ -60,14 +59,6 @@ const ProjectsStore = Reflux.createStore({
6059
this.trigger(new Set([project.id]));
6160
},
6261

63-
onFetchSuccess(project) {
64-
this.itemsById = {
65-
...this.itemsById,
66-
[project.id]: project,
67-
};
68-
this.trigger(new Set([project.id]));
69-
},
70-
7162
onUpdateSuccess(data) {
7263
const project = this.getById(data.id);
7364
const newProject = Object.assign({}, project, data);

0 commit comments

Comments
 (0)