Merge branch 'master' into fix/grouping-config-idempotence

* master: (102 commits)
  fix(symbolicator): Tests are no longer allowed failures (#13566)
  fix(yarn): Fix yarn path in distutils (#13647)
  ref(ui): Remove OrganizationState from a bunch of places (#13646)
  ref(ui): Remove crufty global exports (#13578)
  feat(events-v2): Page loader improvements (#13645)
  fix: Query the right set of issues when given no set of envs for a given first release (#13551)
  feat(ui): update incidents icon (#13622)
  fix(ui): remove rate-limited values from graph when no events are present (#13624)
  feat(events-v2) Add a event graph to the event modal (#13568)
  fix(store): Check project.status is VISIBLE before attempting to process
  perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644)
  tests(percy): Fix Incident status item dynamic time (#13640)
  ref(sentry10): Clean up action creators (#13636)
  ref(app-platform): Backfill IntegrationFeature table (#13548)
  ref(utils): Remove default / reexports from utils.jsx (#13581)
  feat(sentry10): Remove the ability to set a default environment (#13637)
  feat(api): Add url unfurls for incidents to slack integration (SEN-566)
  build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569)
  feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701)
  feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617)
  ...

Author: jan-auer

.travis.yml

@@ -34,7 +34,6 @@ env:
     - DJANGO_VERSION=">=1.8,<1.9"
     # node's version is pinned by .nvmrc and is autodetected by `nvm install`.
     - NODE_DIR="${HOME}/.nvm/versions/node/v$(< .nvmrc)"
-    - YARN_VERSION="1.13.0"
     - NODE_OPTIONS=--max-old-space-size=4096
 
 script:
@@ -55,7 +54,7 @@ after_script:
         pip install codecov
         codecov -e TEST_SUITE
       fi
-  - npm install -g @zeus-ci/cli
+  - ./bin/yarn global add @zeus-ci/cli
   - zeus upload -t "text/xml+xunit" .artifacts/*junit.xml
   - zeus upload -t "text/xml+coverage" .artifacts/*coverage.xml
   - zeus upload -t "text/xml+coverage" .artifacts/coverage/cobertura-coverage.xml
@@ -90,7 +89,6 @@ base_acceptance: &acceptance_default
   before_install:
     - find "$NODE_DIR" -type d -empty -delete
     - nvm install
-    - npm install -g "yarn@${YARN_VERSION}"
     - docker run -d --network host --name clickhouse-server --ulimit nofile=262144:262144 yandex/clickhouse-server:18.14.9
     - docker run -d --network host --name snuba --env SNUBA_SETTINGS=test --env CLICKHOUSE_SERVER=localhost:9000 getsentry/snuba
     - docker ps -a
@@ -117,10 +115,9 @@ matrix:
       name: 'Linter'
       env: TEST_SUITE=lint
       install:
+        - SENTRY_LIGHT_BUILD=1 pip install -e ".[dev,tests,optional]"
         - find "$NODE_DIR" -type d -empty -delete
         - nvm install
-        - npm install -g "yarn@${YARN_VERSION}"
-        - pip install -r requirements-dev.txt
         - yarn install --pure-lockfile
 
     - <<: *postgres_default
@@ -158,7 +155,6 @@ matrix:
       before_install:
         - find "$NODE_DIR" -type d -empty -delete
         - nvm install
-        - npm install -g "yarn@${YARN_VERSION}"
       install:
         - yarn install --pure-lockfile
 
@@ -180,7 +176,6 @@ matrix:
       before_install:
         - find "$NODE_DIR" -type d -empty -delete
         - nvm install
-        - npm install -g "yarn@${YARN_VERSION}"
 
     - <<: *postgres_default
       name: 'Symbolicator Integration'
@@ -225,7 +220,6 @@ matrix:
         - tar -xzf credentials.tar.gz
         # Use the decrypted service account credentials to authenticate the command line tool
         - gcloud auth activate-service-account --key-file client-secret.json
-        - npm install -g "yarn@${YARN_VERSION}"
       install:
         - yarn install --pure-lockfile
         - gcloud version
@@ -239,12 +233,6 @@ matrix:
     - language: node_js
       env: STORYBOOK_BUILD=1
 
-    # XXX(ja): Should be removed once symbolicator's interface is more stable or
-    # tests have been refactored to be more lenient. At the moment, snapshots
-    # break every time when a new attribute is added or some secondary attribute
-    # is changed.
-    - env: TEST_SUITE=symbolicator
-
 notifications:
   webhooks:
     urls:

.travis/deploy-storybook.sh

@@ -10,7 +10,7 @@ BRANCH_PROCESSED=$(echo "${DEPLOY_BRANCH}" | tr '[:upper:]./' '[:lower:]--' | tr
 BUCKET_DIR_NAME="branches/${BRANCH_PROCESSED}"
 echo "Bucket directory: ${BUCKET_DIR_NAME}"
 
-npm run storybook-build
+./bin/yarn run storybook-build
 
 # Upload the files
 gsutil cp .storybook-out/favicon.ico "gs://${GS_BUCKET_NAME}/favicon.ico"

.yarnrc

@@ -0,0 +1,2 @@
+yarn-path "./bin/yarn"
+disable-self-update-check true

Makefile

@@ -8,15 +8,21 @@ ifneq "$(wildcard /usr/local/opt/openssl/lib)" ""
 endif
 
 PIP = LDFLAGS="$(LDFLAGS)" pip
-WEBPACK = NODE_ENV=production ./node_modules/.bin/webpack
-YARN_VERSION = 1.13.0
+WEBPACK = NODE_ENV=production ./bin/yarn webpack
+YARN = ./bin/yarn
 
-bootstrap: install-system-pkgs develop create-db apply-migrations
+bootstrap: install-system-pkgs develop init-config run-dependent-services create-db apply-migrations
 
 develop: setup-git ensure-venv develop-only
 
 develop-only: update-submodules install-yarn-pkgs install-sentry-dev
 
+init-config:
+	sentry init --dev
+
+run-dependent-services:
+	sentry devservices up
+
 test: develop lint test-js test-python test-cli
 
 ensure-venv:
@@ -70,19 +76,17 @@ node-version-check:
 install-system-pkgs: node-version-check
 	@echo "--> Installing system packages (from Brewfile)"
 	@command -v brew 2>&1 > /dev/null && brew bundle || (echo 'WARNING: homebrew not found or brew bundle failed - skipping system dependencies.')
-	@echo "--> Installing yarn $(YARN_VERSION) (via npm)"
-	@$(volta --version 2>&1 > /dev/null || npm install -g "yarn@$(YARN_VERSION)")
 
 install-yarn-pkgs:
 	@echo "--> Installing Yarn packages (for development)"
-	@command -v yarn 2>&1 > /dev/null || (echo 'yarn not found. Please install it before proceeding.'; exit 1)
+	@command -v $(YARN) 2>&1 > /dev/null || (echo 'yarn not found. Please install it before proceeding.'; exit 1)
 	# Use NODE_ENV=development so that yarn installs both dependencies + devDependencies
-	NODE_ENV=development yarn install --pure-lockfile
+	NODE_ENV=development $(YARN) install --pure-lockfile
 	# A common problem is with node packages not existing in `node_modules` even though `yarn install`
 	# says everything is up to date. Even though `yarn install` is run already, it doesn't take into
 	# account the state of the current filesystem (it only checks .yarn-integrity).
 	# Add an additional check against `node_modules`
-	yarn check --verify-tree || yarn install --check-files
+	$(YARN) check --verify-tree || $(YARN) install --check-files
 
 install-sentry-dev:
 	@echo "--> Installing Sentry (for development)"
@@ -129,13 +133,13 @@ test-js: node-version-check
 	@echo "--> Building static assets"
 	@$(WEBPACK) --profile --json > .artifacts/webpack-stats.json
 	@echo "--> Running JavaScript tests"
-	@npm run test-ci
+	@$(YARN) run test-ci
 	@echo ""
 
 # builds and creates percy snapshots
 test-styleguide:
 	@echo "--> Building and snapshotting styleguide"
-	@npm run snapshot
+	@$(YARN) run snapshot
 	@echo ""
 
 test-python:
@@ -244,12 +248,12 @@ scan-python:
 	bin/scan
 	@echo ""
 
-travis-scan-postgres: scan-python
+travis-scan-postgres: travis-noop
 travis-scan-acceptance: travis-noop
-travis-scan-snuba: scan-python
+travis-scan-snuba: travis-noop
 travis-scan-symbolicator: travis-noop
 travis-scan-js: travis-noop
 travis-scan-cli: travis-noop
 travis-scan-dist: travis-noop
-travis-scan-lint: travis-noop
-travis-scan-riak: scan-python
+travis-scan-lint: scan-python
+travis-scan-riak: travis-noop

api-docs/generator.py

@@ -282,8 +282,8 @@ def dump_markdown(path, data):
         pass
     with open(path, 'w') as f:
         template = u"""---
-# This file is automatically generated from the API using `api-docs/generate.py`
-# Do not manually this file.
+# This file is automatically generated from the API using `sentry/api-docs/generator.py.`
+# Do not manually edit this file.
 {}
 ---
 """

babel.config.js

@@ -18,7 +18,10 @@ module.exports = {
   env: {
     production: {},
     development: {
-      plugins: [['emotion', {sourceMap: true, autoLabel: true}]],
+      plugins: [
+        ['emotion', {sourceMap: true, autoLabel: true}],
+        '@babel/plugin-transform-react-jsx-source',
+      ],
     },
     test: {
       plugins: [['emotion', {autoLabel: true}], 'dynamic-import-node'],