Skip to content

Commit 93d7b73

Browse files
authored
feat(logs): minor accordion cleanup (#89531)
- Removed extra table row wrapper (which adds an extra white background) ![Screenshot 2025-04-15 at 9 01 18 AM](https://github.com/user-attachments/assets/3011aad3-6211-4989-a239-a745ec918fa3) - Added border top and bottom of log details
1 parent c980de6 commit 93d7b73

File tree

2 files changed

+37
-38
lines changed

2 files changed

+37
-38
lines changed

static/app/views/explore/logs/logsTableRow.tsx

Lines changed: 35 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {useLocation} from 'sentry/utils/useLocation';
1515
import useOrganization from 'sentry/utils/useOrganization';
1616
import CellAction, {Actions} from 'sentry/views/discover/table/cellAction';
1717
import type {TableColumn} from 'sentry/views/discover/table/types';
18-
import {TableRow} from 'sentry/views/explore/components/table';
1918
import {
2019
useLogsAnalyticsPageSource,
2120
useLogsFields,
@@ -254,43 +253,41 @@ function LogRowDetails({
254253
}
255254
return (
256255
<DetailsWrapper>
257-
<TableRow>
258-
<LogDetailTableBodyCell colSpan={fields.length}>
259-
{isPending && <LoadingIndicator />}
260-
{!isPending && data && (
261-
<Fragment>
262-
<DetailsContent>
263-
<DetailsBody>
264-
{LogBodyRenderer({
265-
item: getLogRowItem(OurLogKnownFieldKey.MESSAGE, dataRow, meta),
266-
extra: {
267-
highlightTerms,
268-
logColors,
269-
wrapBody: true,
270-
location,
271-
organization,
272-
},
273-
})}
274-
</DetailsBody>
275-
<LogDetailPanelItem>
276-
<LogFieldsTree
277-
attributes={data.attributes}
278-
hiddenAttributes={HiddenLogDetailFields}
279-
renderers={LogAttributesRendererMap}
280-
renderExtra={{
281-
highlightTerms,
282-
logColors,
283-
location,
284-
organization,
285-
}}
286-
tableResultLogRow={dataRow}
287-
/>
288-
</LogDetailPanelItem>
289-
</DetailsContent>
290-
</Fragment>
291-
)}
292-
</LogDetailTableBodyCell>
293-
</TableRow>
256+
<LogDetailTableBodyCell colSpan={fields.length}>
257+
{isPending && <LoadingIndicator />}
258+
{!isPending && data && (
259+
<Fragment>
260+
<DetailsContent>
261+
<DetailsBody>
262+
{LogBodyRenderer({
263+
item: getLogRowItem(OurLogKnownFieldKey.MESSAGE, dataRow, meta),
264+
extra: {
265+
highlightTerms,
266+
logColors,
267+
wrapBody: true,
268+
location,
269+
organization,
270+
},
271+
})}
272+
</DetailsBody>
273+
<LogDetailPanelItem>
274+
<LogFieldsTree
275+
attributes={data.attributes}
276+
hiddenAttributes={HiddenLogDetailFields}
277+
renderers={LogAttributesRendererMap}
278+
renderExtra={{
279+
highlightTerms,
280+
logColors,
281+
location,
282+
organization,
283+
}}
284+
tableResultLogRow={dataRow}
285+
/>
286+
</LogDetailPanelItem>
287+
</DetailsContent>
288+
</Fragment>
289+
)}
290+
</LogDetailTableBodyCell>
294291
</DetailsWrapper>
295292
);
296293
}

static/app/views/explore/logs/styles.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ export const DetailsWrapper = styled('div')`
105105
flex-direction: column;
106106
white-space: nowrap;
107107
grid-column: 1 / -1;
108+
border-top: 1px solid ${p => p.theme.border};
109+
border-bottom: 1px solid ${p => p.theme.border};
108110
z-index: ${2 /* place above the grid resizing lines */};
109111
`;
110112

0 commit comments

Comments
 (0)