Skip to content

Commit 6ee92e5

Browse files
armenzgChristinarlong
authored andcommitted
feat(grouping): Do not categorize these packages as in-app (#88787)
Categorizing these frames will prevent deriving in-app stack trace rules for them. A flaw with my system is that many Java packages can be forked, thus, the derivation system will categorize them as in-app.
1 parent b584bcd commit 6ee92e5

File tree

7 files changed

+151
-144
lines changed

7 files changed

+151
-144
lines changed

src/sentry/grouping/enhancer/enhancement-configs/newstyle@2023-01-11.txt

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -429,20 +429,27 @@ function:nextTick -app -group
429429
path:**/go/pkg/mod/** -app
430430

431431
## java
432-
module:jdk.* -app
433-
module:sun.* -app
434-
module:com.sun.* -app
435-
module:java.* -app
436-
module:scala.* -app
437-
module:akka.* -app
438-
module:javax.* -app
439-
module:org.apache.* -app
440-
module:org.springframework.* -app
441-
module:org.glassfish.* -app
442-
module:org.jboss.* -app
443-
module:feign.* -app
444-
module:io.opentelemetry.* -app
445-
module:io.sentry.* -app -group
432+
module:akka.* category=framework
433+
module:com.fasterxml.* category=framework
434+
module:com.microsoft.* category=framework
435+
module:com.sun.* category=framework
436+
module:feign.* category=framework
437+
module:io.opentelemetry.* category=framework
438+
module:io.sentry.* category=framework -group
439+
module:jdk.* category=framework
440+
module:oauth.* category=framework
441+
module:org.apache.* category=framework
442+
module:org.glassfish.* category=framework
443+
module:org.jboss.* category=framework
444+
module:org.jdesktop.* category=framework
445+
module:org.postgresql.* category=framework
446+
module:org.springframework.* category=framework
447+
module:org.web3j.* category=framework
448+
module:reactor.core.* category=framework
449+
module:scala.* category=framework
450+
module:sun.* category=framework
451+
452+
category:framework -app
446453

447454
## kotlin
448455
module:kotlin.* -app

tests/sentry/grouping/snapshots/test_variants/test_event_hash_variant/newstyle@2023_01_11/android_anr.pysnap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
created: '2025-02-26T00:33:56.483613+00:00'
2+
created: '2025-04-04T17:56:16.235509+00:00'
33
creator: sentry
44
source: tests/sentry/grouping/test_variants.py
55
---
@@ -24,14 +24,14 @@ app:
2424
"zygoteinit.java"
2525
function*
2626
"run"
27-
frame (marked out of app by stack trace rule (module:java.* -app))
27+
frame (non app frame)
2828
module*
2929
"java.lang.reflect.Method"
3030
filename (module takes precedence)
3131
"method.java"
3232
function*
3333
"invoke"
34-
frame (marked out of app by stack trace rule (module:java.* -app))
34+
frame (non app frame)
3535
module*
3636
"java.lang.reflect.Method"
3737
filename (module takes precedence)
@@ -772,7 +772,7 @@ app:
772772
"Application Not Responding for at least <int> ms."
773773
threads (ignored because this variant does not have a contributing stacktrace, but the system variant does)
774774
stacktrace (ignored because it contains no in-app frames)
775-
frame (marked out of app by stack trace rule (module:java.* -app))
775+
frame (non app frame)
776776
module*
777777
"java.lang.Thread"
778778
filename (module takes precedence)
@@ -808,14 +808,14 @@ system:
808808
"zygoteinit.java"
809809
function*
810810
"run"
811-
frame
811+
frame (ignored by stack trace rule (category:threadbase -group v-group))
812812
module*
813813
"java.lang.reflect.Method"
814814
filename (module takes precedence)
815815
"method.java"
816816
function*
817817
"invoke"
818-
frame
818+
frame (ignored by stack trace rule (category:threadbase -group v-group))
819819
module*
820820
"java.lang.reflect.Method"
821821
filename (module takes precedence)

tests/sentry/grouping/snapshots/test_variants/test_event_hash_variant/newstyle@2023_01_11/frame_ignores_sun_java_generated_constructors.pysnap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
created: '2025-02-26T00:34:03.980784+00:00'
2+
created: '2025-04-07T18:37:31.787929+00:00'
33
creator: sentry
44
source: tests/sentry/grouping/test_variants.py
55
---
@@ -9,7 +9,7 @@ app:
99
component:
1010
app (stacktrace of system takes precedence)
1111
stacktrace (ignored because it contains no in-app frames)
12-
frame (marked out of app by stack trace rule (module:sun.* -app))
12+
frame (marked out of app by stack trace rule (category:framework -app))
1313
module* (removed codegen marker)
1414
"sun.reflect.GeneratedSerializationConstructorAccessor<auto>"
1515
function*

tests/sentry/grouping/snapshots/test_variants/test_event_hash_variant/newstyle@2023_01_11/frame_ignores_sun_java_generated_constructors_2.pysnap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
created: '2025-02-26T00:34:03.878371+00:00'
2+
created: '2025-04-07T18:37:31.505448+00:00'
33
creator: sentry
44
source: tests/sentry/grouping/test_variants.py
55
---
@@ -9,7 +9,7 @@ app:
99
component:
1010
app (stacktrace of system takes precedence)
1111
stacktrace (ignored because it contains no in-app frames)
12-
frame (marked out of app by stack trace rule (module:sun.* -app))
12+
frame (marked out of app by stack trace rule (category:framework -app))
1313
module* (removed codegen marker)
1414
"sun.reflect.GeneratedConstructorAccessor<auto>"
1515
function*

tests/sentry/grouping/snapshots/test_variants/test_event_hash_variant/newstyle@2023_01_11/frame_ignores_sun_java_generated_methods.pysnap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
created: '2025-02-26T00:34:04.071130+00:00'
2+
created: '2025-04-07T18:37:32.081584+00:00'
33
creator: sentry
44
source: tests/sentry/grouping/test_variants.py
55
---
@@ -9,12 +9,12 @@ app:
99
component:
1010
app (stacktrace of system takes precedence)
1111
stacktrace (ignored because it contains no in-app frames)
12-
frame (marked out of app by stack trace rule (module:sun.* -app))
12+
frame (marked out of app by stack trace rule (category:framework -app))
1313
module* (removed reflection marker)
1414
"sun.reflect.GeneratedMethodAccessor"
1515
function*
1616
"invoke"
17-
frame (marked out of app by stack trace rule (module:jdk.* -app))
17+
frame (marked out of app by stack trace rule (category:framework -app))
1818
module* (removed reflection marker)
1919
"jdk.internal.reflect.GeneratedMethodAccessor"
2020
function*

0 commit comments

Comments
 (0)