fix(taskworker) Fix async notification parameter serialization (#91720)

RpcUser objects can contain frozenset() which needs to be downcast for
JSON encoding.

Author: markstory

src/sentry/notifications/utils/tasks.py

@@ -31,6 +31,8 @@ def serialize_lazy_object_user(arg: SimpleLazyObject, key: str | None = None) ->
     for k, v in raw_data.items():
         if isinstance(v, datetime):
             v = v.isoformat()
+        if isinstance(v, frozenset):
+            v = list(v)
 
         parsed_data[k] = v
 

tests/sentry/notifications/utils/test_tasks.py

@@ -2,11 +2,13 @@
 
 import pytest
 from django.contrib.auth.models import AnonymousUser
+from django.utils.functional import SimpleLazyObject
 
 from sentry.notifications.class_manager import NotificationClassNotSetException, manager, register
 from sentry.notifications.utils.tasks import _send_notification, async_send_notification
 from sentry.testutils.cases import TestCase
 from sentry.testutils.helpers.notifications import AnotherDummyNotification, DummyNotification
+from sentry.users.services.user.serial import serialize_generic_user
 
 
 class NotificationTaskTests(TestCase):
@@ -83,6 +85,32 @@ def test_call_task_with_anonymous_user(self, mock_delay):
             ],
         )
 
+    @patch("sentry.notifications.utils.tasks._send_notification.delay")
+    def test_call_task_with_lazy_object_user(self, mock_delay):
+        register()(AnotherDummyNotification)
+
+        lazyuser = SimpleLazyObject(lambda: serialize_generic_user(self.user))
+        async_send_notification(AnotherDummyNotification, user=lazyuser)
+        rpc_user = serialize_generic_user(self.user)
+        assert rpc_user
+        expected_data = rpc_user.dict()
+        expected_data["emails"] = list(expected_data["emails"])
+        expected_data["useremails"] = list(expected_data["useremails"])
+        expected_data["roles"] = list(expected_data["roles"])
+        expected_data["permissions"] = list(expected_data["permissions"])
+        expected_data["last_active"] = expected_data["last_active"].isoformat()
+
+        mock_delay.assert_called_with(
+            "AnotherDummyNotification",
+            [
+                {
+                    "type": "lazyobjectrpcuser",
+                    "data": expected_data,
+                    "key": "user",
+                },
+            ],
+        )
+
     @patch(
         "sentry.testutils.helpers.notifications.AnotherDummyNotification",
     )