1515 CodeMapping ,
1616 CodeMappingTreesHelper ,
1717 FrameFilename ,
18+ NeedsExtension ,
1819 UnexpectedPathException ,
1920 UnsupportedFrameFilename ,
2021 convert_stacktrace_frame_path_to_source_path ,
2627from sentry .testutils .silo import assume_test_silo_mode
2728from sentry .utils .event_frames import EventFrame
2829
29- sentry_files = [
30+ SENTRY_FILES = [
3031 "bin/__init__.py" ,
3132 "bin/example1.py" ,
3233 "bin/example2.py" ,
3738 "src/sentry/wsgi.py" ,
3839 "src/sentry_plugins/slack/client.py" ,
3940]
40-
41-
4241UNSUPPORTED_FRAME_FILENAMES = [
4342 "async https://s1.sentry-cdn.com/_static/dist/sentry/entrypoints/app.js" ,
4443 "/gtm.js" , # Top source; starts with backslash
4746 "[native code]" ,
4847 "O$t" ,
4948 "async https://s1.sentry-cdn.com/_static/dist/sentry/entrypoints/app.js" ,
50- "/foo/bar/baz" , # no extension
51- "README" , # no extension
49+ "README" , # top level file
5250 "ssl.py" ,
5351 # XXX: The following will need to be supported
5452 "initialization.dart" ,
5553 "backburner.js" ,
5654]
55+ NO_EXTENSION_FRAME_FILENAMES = [
56+ "/foo/bar/baz" , # no extension
57+ ]
5758
5859
5960class TestRepoFiles (TestCase ):
6061 """These evaluate which files should be included as part of a repo."""
6162
6263 def test_filter_source_code_files (self ) -> None :
63- source_code_files = filter_source_code_files (sentry_files )
64+ source_code_files = filter_source_code_files (SENTRY_FILES )
6465
6566 assert source_code_files .index ("bin/__init__.py" ) == 0
6667 assert source_code_files .index ("docs-ui/.eslintrc.js" ) == 3
@@ -109,19 +110,6 @@ def test_buckets_logic() -> None:
109110
110111
111112class TestFrameFilename :
112- def test_frame_filename_package_and_more_than_one_level (self ) -> None :
113- pytest .skip ("This test is outdated because of refactors have been made to code mappings" )
114- # ff = FrameFilename("getsentry/billing/tax/manager.py")
115- # assert f"{ff.root}/{ff.dir_path}/{ff.file_name}" == "getsentry/billing/tax/manager.py"
116- # assert f"{ff.dir_path}/{ff.file_name}" == ff.file_and_dir_path
117-
118- def test_frame_filename_package_and_no_levels (self ) -> None :
119- pytest .skip ("This test is outdated because of refactors have been made to code mappings" )
120- # ff = FrameFilename("root/bar.py")
121- # assert f"{ff.root}/{ff.file_name}" == "root/bar.py"
122- # assert f"{ff.root}/{ff.file_and_dir_path}" == "root/bar.py"
123- # assert ff.dir_path == ""
124-
125113 def test_frame_filename_repr (self ) -> None :
126114 path = "getsentry/billing/tax/manager.py"
127115 assert FrameFilename ({"filename" : path }).__repr__ () == f"FrameFilename: { path }
@@ -131,6 +119,11 @@ def test_raises_unsupported(self) -> None:
131119 with pytest .raises (UnsupportedFrameFilename ):
132120 FrameFilename ({"filename" : filepath })
133121
122+ def test_raises_no_extension (self ) -> None :
123+ for filepath in NO_EXTENSION_FRAME_FILENAMES :
124+ with pytest .raises (NeedsExtension ):
125+ FrameFilename ({"filename" : filepath })
126+
134127 @pytest .mark .parametrize (
135128 "frame_filename, prefix" ,
136129 [
@@ -167,7 +160,7 @@ def setUp(self) -> None:
167160 self .bar_repo = RepoAndBranch ("Test-Organization/bar" , "main" )
168161 self .code_mapping_helper = CodeMappingTreesHelper (
169162 {
170- self .foo_repo .name : RepoTree (self .foo_repo , files = sentry_files ),
163+ self .foo_repo .name : RepoTree (self .foo_repo , files = SENTRY_FILES ),
171164 self .bar_repo .name : RepoTree (self .bar_repo , files = ["sentry/web/urls.py" ]),
172165 }
173166 )
@@ -303,52 +296,76 @@ def test_list_file_matches_multiple(self) -> None:
303296 assert matches == expected_matches
304297
305298 def test_find_roots_starts_with_period_slash (self ) -> None :
306- stacktrace_root , source_path = find_roots ("./app/" , "static/app/" )
299+ stacktrace_root , source_path = find_roots (
300+ FrameFilename ({"filename" : "./app/foo.tsx" }), "static/app/foo.tsx"
301+ )
307302 assert stacktrace_root == "./"
308303 assert source_path == "static/"
309304
310305 def test_find_roots_starts_with_period_slash_no_containing_directory (self ) -> None :
311- stacktrace_root , source_path = find_roots ("./app/" , "app/" )
306+ stacktrace_root , source_path = find_roots (
307+ FrameFilename ({"filename" : "./app/foo.tsx" }), "app/foo.tsx"
308+ )
312309 assert stacktrace_root == "./"
313310 assert source_path == ""
314311
315312 def test_find_roots_not_matching (self ) -> None :
316- stacktrace_root , source_path = find_roots ("sentry/" , "src/sentry/" )
313+ stacktrace_root , source_path = find_roots (
314+ FrameFilename ({"filename" : "sentry/foo.py" }), "src/sentry/foo.py"
315+ )
317316 assert stacktrace_root == "sentry/"
318317 assert source_path == "src/sentry/"
319318
320319 def test_find_roots_equal (self ) -> None :
321- stacktrace_root , source_path = find_roots ("source/" , "source/" )
320+ stacktrace_root , source_path = find_roots (
321+ FrameFilename ({"filename" : "source/foo.py" }), "source/foo.py"
322+ )
322323 assert stacktrace_root == ""
323324 assert source_path == ""
324325
325326 def test_find_roots_starts_with_period_slash_two_levels (self ) -> None :
326- stacktrace_root , source_path = find_roots ("./app/" , "app/foo/app/" )
327+ stacktrace_root , source_path = find_roots (
328+ FrameFilename ({"filename" : "./app/foo.tsx" }), "app/foo/app/foo.tsx"
329+ )
327330 assert stacktrace_root == "./"
328331 assert source_path == "app/foo/"
329332
330333 def test_find_roots_starts_with_app (self ) -> None :
331- stacktrace_root , source_path = find_roots ("app:///utils/" , "utils/" )
334+ stacktrace_root , source_path = find_roots (
335+ FrameFilename ({"filename" : "app:///utils/foo.tsx" }), "utils/foo.tsx"
336+ )
332337 assert stacktrace_root == "app:///"
333338 assert source_path == ""
334339
335340 def test_find_roots_starts_with_multiple_dot_dot_slash (self ) -> None :
336- stacktrace_root , source_path = find_roots ("../../../../../../packages/" , "packages/" )
341+ stacktrace_root , source_path = find_roots (
342+ FrameFilename ({"filename" : "../../../../../../packages/foo.tsx" }),
343+ "packages/foo.tsx" ,
344+ )
337345 assert stacktrace_root == "../../../../../../"
338346 assert source_path == ""
339347
340348 def test_find_roots_starts_with_app_dot_dot_slash (self ) -> None :
341- stacktrace_root , source_path = find_roots ("app:///../services/" , "services/" )
349+ stacktrace_root , source_path = find_roots (
350+ FrameFilename ({"filename" : "app:///../services/foo.tsx" }),
351+ "services/foo.tsx" ,
352+ )
342353 assert stacktrace_root == "app:///../"
343354 assert source_path == ""
344355
345356 def test_find_roots_bad_stack_path (self ) -> None :
346357 with pytest .raises (UnexpectedPathException ):
347- find_roots ("https://yrurlsinyourstackpath.com/" , "sentry/something.py" )
358+ find_roots (
359+ FrameFilename ({"filename" : "https://yrurlsinyourstackpath.com/" }),
360+ "sentry/something.py" ,
361+ )
348362
349363 def test_find_roots_bad_source_path (self ) -> None :
350364 with pytest .raises (UnexpectedPathException ):
351- find_roots ("sentry/random.py" , "nothing/something.js" )
365+ find_roots (
366+ FrameFilename ({"filename" : "sentry/random.py" }),
367+ "nothing/something.js" ,
368+ )
352369
353370
354371class TestConvertStacktraceFramePathToSourcePath (TestCase ):
0 commit comments