-
-
Notifications
You must be signed in to change notification settings - Fork 61
feat(react-native): Add Feedback Widget step #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 27.21% 27.24% +0.03%
==========================================
Files 129 129
Lines 14218 14284 +66
Branches 843 849 +6
==========================================
+ Hits 3869 3892 +23
- Misses 10331 10374 +43
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
return ` integrations: [${ | ||
enableSessionReplay ? 'Sentry.mobileReplayIntegration()' : '' | ||
}${enableSessionReplay && enableFeedbackWidget ? ', ' : ''}${ | ||
enableFeedbackWidget ? 'Sentry.feedbackIntegration()' : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding the integration for now. We may add more options with with feature drop 2 (e.g. enable capture screenshot)
# Conflicts: # CHANGELOG.md # src/react-native/javascript.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Ty!
Add a step asking user if they want to add the feedback widget.
Part of getsentry/sentry-react-native#4302