-
-
Notifications
You must be signed in to change notification settings - Fork 61
feat(nextjs): add connectivity check to example page #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs): add connectivity check to example page #951
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
=======================================
Coverage 24.24% 24.24%
=======================================
Files 121 121
Lines 12877 12877
Branches 713 713
=======================================
Hits 3122 3122
Misses 9734 9734
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2ef6d3d
to
b7b3869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beaut
(random thought: some applications put the Next.js devserver floaty thingy in the bottom right corner so idk whether the bottom right corner is a good place for the alert box. If it's easy I would put it in the center of the page with the other content but no biggie if that is too hard.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Nit: Can we slightly tweak the copy so that we take up only 3 lines? That one word in the fourth line makes it more massive than it needs to be.
diagnoseSdkConnectivity()
function to programmatically detect possible connectivity issues sentry-javascript#15821Before:

After:
