Skip to content

feat(nextjs): add connectivity check to example page #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented Apr 15, 2025

Before:
Screenshot 2025-04-15 at 14 47 49

After:
Screenshot 2025-04-16 at 09 21 45

Copy link

github-actions bot commented Apr 15, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8025734

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.24%. Comparing base (e36505b) to head (8025734).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #951   +/-   ##
=======================================
  Coverage   24.24%   24.24%           
=======================================
  Files         121      121           
  Lines       12877    12877           
  Branches      713      713           
=======================================
  Hits         3122     3122           
  Misses       9734     9734           
  Partials       21       21           
Flag Coverage Δ
unit-tests 24.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shellmayr shellmayr force-pushed the shellmayr/feat/add-bad-connection-detection-nextjs branch from 2ef6d3d to b7b3869 Compare April 15, 2025 13:40
@shellmayr shellmayr marked this pull request as ready for review April 15, 2025 13:41
@shellmayr shellmayr requested review from a team and lforst April 15, 2025 13:41
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beaut

(random thought: some applications put the Next.js devserver floaty thingy in the bottom right corner so idk whether the bottom right corner is a good place for the alert box. If it's easy I would put it in the center of the page with the other content but no biggie if that is too hard.)

@shellmayr shellmayr requested a review from matejminar April 15, 2025 15:24
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Nit: Can we slightly tweak the copy so that we take up only 3 lines? That one word in the fourth line makes it more massive than it needs to be.

@shellmayr shellmayr merged commit 605555b into master Apr 16, 2025
16 checks passed
@shellmayr shellmayr deleted the shellmayr/feat/add-bad-connection-detection-nextjs branch April 16, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants