Skip to content

feat: Adding the game's name to the app context #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Conversation

bitsandfoxes
Copy link
Contributor

Adding the game's name to the app context. This should be especially helpful in case of UaaL.

Screenshot 2025-03-27 at 15 16 26

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Adding the game's name to the app context ([#2083](https://github.com/getsentry/sentry-unity/pull/2083))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against c0e50ba

@bitsandfoxes bitsandfoxes changed the title setting app.name feat: Adding the game's name to the app context Mar 27, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the game's name to the app context so that it can be reported alongside other app metadata. The changes update the integration code to assign the game's name from the application, add tests to verify that the value is set correctly, and update the changelog accordingly.

  • Updated the integration code to assign the game's name
  • Added tests to verify that the game's name is set in the app context
  • Updated the changelog with the new feature

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/Sentry.Unity.Tests/UnityEventScopeTests.cs Added tests to verify that the app context properly includes the game's name
src/Sentry.Unity/Integrations/UnityScopeIntegration.cs Updated to assign the game's name to the app context
CHANGELOG.md Updated changelog with a note about the new feature

@bitsandfoxes bitsandfoxes merged commit 6daa7fe into main Apr 2, 2025
13 of 14 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/app-name branch April 2, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants