Skip to content

feat(tracing): support combined EventFilters and EventMappings #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 18, 2025

It seems common enough that someone would want to want to map a tracing event to multiple item types, and right now that's not possible, you have to choose between Ignore/Event/Breadcrumb/Log.
For example, in Relay we want to send everything at or above INFO level to logs, while still sending ERROR events to Sentry events at the same time.

This is a proposal for how to implement that.
This particular solution requires 2 breaking changes, even though both could be avoided.
I would argue that they are not actually breaking for most users though, i.e. those that just set up a custom filter, as this is still backwards compatible in terms of syntax, even though the underlying type changes.

Copy link

github-actions bot commented Jun 18, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 07dd2c7

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.21%. Comparing base (333b14e) to head (07dd2c7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   74.05%   74.21%   +0.16%     
==========================================
  Files          64       64              
  Lines        7781     7807      +26     
==========================================
+ Hits         5762     5794      +32     
+ Misses       2019     2013       -6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lcian lcian requested a review from Swatinem June 18, 2025 13:15
@lcian lcian marked this pull request as ready for review June 20, 2025 08:48
@lcian lcian merged commit 20a5d48 into master Jun 23, 2025
18 checks passed
@lcian lcian deleted the lcian/feat/tracing-multiple-mappings branch June 23, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants