Skip to content

refactor: remove Surf transport #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

refactor: remove Surf transport #766

merged 2 commits into from
Apr 10, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Apr 10, 2025

Removes the Surf transport and feature flag.
Surf is unmaintained (last commit 3 years ago). It depends on http-client which in turn drags in lexical-core <1.0.0 which is associated with this dependabot alert https://github.com/getsentry/sentry-rust/security/dependabot/11.
People will still be able to use Surf if they really want to by providing their own transport factory.

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I remember this was holding back some dependency updates. might be good to revisit those either here, or in a followup PR.

@lcian lcian merged commit 2488671 into master Apr 10, 2025
14 checks passed
@lcian lcian deleted the lcian/ref/remove-surf branch April 10, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants