Skip to content

chore(deps): bump rustls #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

utkarshgupta137
Copy link
Contributor

ureq 2.7 is using rustls 0.21 now, so sentry won't build if both rustls & ureq are enabled.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #592 (e6ac0fb) into master (b594f83) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e6ac0fb differs from pull request most recent head 322a7c1. Consider uploading reports for the commit 322a7c1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   70.79%   70.80%           
=======================================
  Files          67       67           
  Lines        6856     6857    +1     
=======================================
+ Hits         4854     4855    +1     
  Misses       2002     2002           

@Swatinem Swatinem merged commit e3bdd32 into getsentry:master Jun 15, 2023
@utkarshgupta137 utkarshgupta137 deleted the bump/rustls branch June 15, 2023 17:20
@utkarshgupta137
Copy link
Contributor Author

@Swatinem Can you do a release, our CIs are broken.

@Swatinem
Copy link
Member

Release is triggered: getsentry/publish#2384
It still needs to be approved and will then go out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants