Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 3.0. #613

Closed
wants to merge 9 commits into from
Closed

Conversation

nateberkopec
Copy link
Contributor

@nateberkopec nateberkopec commented Dec 16, 2016

@nateberkopec nateberkopec changed the title WIP: 3.0. Local variables, performance, refactor. WIP: 3.0. Mar 22, 2017
@nateberkopec
Copy link
Contributor Author

Ultimately I decided not to include local variable capture - it's too unstable and buggy and could never be used in production, so the use case is too limited.

@nateberkopec
Copy link
Contributor Author

Just realized we'll need a 2.x series release where to_hash uses string keys and still supports symbol keys in order to provide a smooth transition to 3.0. Otherwise, peoples events in background job processors will get eaten up.

Remove “capture” methods on Raven::Event, which no one should have been
using directly anyway because those methods didn’t “capture” anything,
only converted strings/exceptions into Events. I’m not going to do a
deprecation cycle for this because no one should have been using these
aliases anyway, and they were only used in our tests. I do recognize
that from_exception is now changed so that it no longer checks
Raven::Error or excluded exception (that’s now in capture_allowed?), so
this will trigger a major release.
+ Config can be passed variables during init
+ Spec -> Minitest
+ Bad encoding raises ArgumentError
+ ResolveHostname - fix bug where FQDN was not resolved
+ Note bug where module exclusion doesn’t work properly
@nateberkopec nateberkopec force-pushed the binding-of-caller branch 2 times, most recently from 24c65cc to 04bd6ed Compare May 10, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant