Skip to content

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Sep 17, 2025

  • Cleanup before_send to only apply to ErrorEvent
  • also remove the Hash deprecation message

Issues

@sl0thentr0py sl0thentr0py requested a review from solnic September 17, 2025 10:48
@sl0thentr0py sl0thentr0py force-pushed the neel/fix-before-send-behavior branch from eebf084 to 0d6d22d Compare September 17, 2025 10:57
@sl0thentr0py sl0thentr0py force-pushed the 6.0-dev branch 2 times, most recently from 10946fb to 4fa52f3 Compare September 17, 2025 10:58
@sl0thentr0py sl0thentr0py force-pushed the neel/fix-before-send-behavior branch 2 times, most recently from f46216e to 106e8d6 Compare September 17, 2025 12:35
@sl0thentr0py sl0thentr0py changed the title Cleanup before_send to only apply to ErrorEvent Add before_send_check_in Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.69%. Comparing base (4fa52f3) to head (76aebb0).
⚠️ Report is 1 commits behind head on 6.0-dev.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/client.rb 23.07% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4fa52f3) and HEAD (76aebb0). Click for more details.

HEAD has 65 uploads less than BASE
Flag BASE (4fa52f3) HEAD (76aebb0)
85 20
Additional details and impacted files
@@             Coverage Diff             @@
##           6.0-dev    #2703      +/-   ##
===========================================
- Coverage    65.58%   56.69%   -8.89%     
===========================================
  Files          139      130       -9     
  Lines         5416     5092     -324     
===========================================
- Hits          3552     2887     -665     
- Misses        1864     2205     +341     
Components Coverage Δ
sentry-ruby 54.52% <44.44%> (+0.65%) ⬆️
sentry-rails 43.00% <ø> (-53.29%) ⬇️
sentry-sidekiq 96.44% <ø> (-0.14%) ⬇️
sentry-resque 94.20% <ø> (-0.25%) ⬇️
sentry-delayed_job ∅ <ø> (∅)
sentry-opentelemetry 100.00% <ø> (+0.68%) ⬆️
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 81.46% <100.00%> (+0.56%) ⬆️
sentry-ruby/lib/sentry/client.rb 36.84% <23.07%> (+0.89%) ⬆️

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-before-send-behavior branch 2 times, most recently from 3b51b10 to ba66348 Compare September 17, 2025 12:51
Copy link

linear bot commented Sep 17, 2025

This was referenced Sep 17, 2025
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left just one suggestion re CHANGELOG.

* Cleanup before_send to only apply to ErrorEvent
* remove the Hash deprecation message
@sl0thentr0py sl0thentr0py force-pushed the neel/fix-before-send-behavior branch from ba66348 to 76aebb0 Compare September 18, 2025 09:47
@sl0thentr0py sl0thentr0py merged commit f9d8202 into 6.0-dev Sep 18, 2025
132 of 135 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-before-send-behavior branch September 18, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants