Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move envelope item processing/trimming logic to the Item class #1824

Merged
merged 5 commits into from
May 20, 2022
Merged

Move envelope item processing/trimming logic to the Item class #1824

merged 5 commits into from
May 20, 2022

Commits on May 20, 2022

  1. Extract item trimming logic from Transport 

    Item should take care of this check/trimming process and return the best
result it can provide, instead of going back-and-forth with the
Transport class.
    @st0012
    st0012 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    1d01aff View commit details
    Browse the repository at this point in the history

  2. Move MAX_SERIALIZED_PAYLOAD_SIZE to Item class 

    The size limitation is Item's concern instead of Event's, so it makes
more sense to define it in the Item class.
    @st0012
    st0012 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    e11a4d3 View commit details
    Browse the repository at this point in the history

  3. Item should encapsulate all the size-related logic

    @st0012
    st0012 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    e639e2d View commit details
    Browse the repository at this point in the history

  4. Change log level for dropping oversized items 

    We use info level for other event related actions (dropping/sending). So
we should also use the same level when an event is being dropped due to
oversize.
    @st0012
    st0012 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    cf54ccf View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @st0012
    st0012 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    b6ab2dc View commit details
    Browse the repository at this point in the history