Move envelope item processing/trimming logic to the Item class
#1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Item should take care of this check/trimming process and return the best result it can provide, instead of going back-and-forth with the Transport class.
The size limitation is Item's concern instead of Event's, so it makes more sense to define it in the Item class.
We use info level for other event related actions (dropping/sending). So we should also use the same level when an event is being dropped due to oversize.
Codecov Report
@@ Coverage Diff @@
## master #1824 +/- ##
==========================================
+ Coverage 98.39% 98.46% +0.06%
==========================================
Files 145 145
Lines 8657 8659 +2
==========================================
+ Hits 8518 8526 +8
+ Misses 139 133 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think size-control logic should live inside the
Itemclass andTransport#serialize_envelopeonly needs to decide whether the result should be included in the envelope.