Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): Sync activerecord and net-http span names #1681

Merged
merged 5 commits into from
Feb 1, 2022

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jan 10, 2022

The span prefixes are needed as documented here for the discover slow ops dashboards to be populated successfully.

Note that this won't break any existing user queries since we currently don't allow filtering/searching by span ops.

Fixes #1674

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you also add a changelog entry for it?

@st0012
Copy link
Collaborator

st0012 commented Jan 10, 2022

@sl0thentr0py sorry I missed one thing: perhaps we can also add template. prefix to ActionView's tracers?

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #1681 (e3244bf) into master (9889bbe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
+ Coverage   98.37%   98.39%   +0.01%     
==========================================
  Files         136      136              
  Lines        7830     7833       +3     
==========================================
+ Hits         7703     7707       +4     
+ Misses        127      126       -1     
Impacted Files Coverage Δ
...lib/sentry/rails/tracing/action_view_subscriber.rb 100.00% <100.00%> (ø)
...b/sentry/rails/tracing/active_record_subscriber.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/activejob_spec.rb 99.37% <100.00%> (ø)
...entry/rails/tracing/action_view_subscriber_spec.rb 100.00% <100.00%> (ø)
...try/rails/tracing/active_record_subscriber_spec.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/tracing_spec.rb 99.16% <100.00%> (ø)
sentry-ruby/lib/sentry/net/http.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/net/http_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9889bbe...e3244bf. Read the comment docs.

@sl0thentr0py
Copy link
Member Author

Yea I added those then removed it because I wasn't able to make it clean. The db one works with prefixes, if we go with a prefix for views it'll look like template.render_template.action_view.

Nicer would be template.render.action_view? In that case I'll go with a mapping hash instead of a prefix. What do you think?

@sl0thentr0py
Copy link
Member Author

nvm I just added the prefix, it's not the nicest looking with repetition but it's fine for now..

@st0012
Copy link
Collaborator

st0012 commented Jan 10, 2022

Since it's to support a feature, I think the duplication is fine.

@st0012 st0012 modified the milestones: 5.0.0, 5.1.0 Jan 10, 2022
Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature! I'll put this to 5.1.0 release, which will be released soon after 5.0

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@st0012 st0012 merged commit 8538717 into master Feb 1, 2022
@st0012 st0012 deleted the sync-span-names branch February 1, 2022 10:25
lewispb added a commit to lewispb/sentry-ruby that referenced this pull request Feb 1, 2022
* master:
  feat(performance): Sync activerecord and net-http span names (getsentry#1681)
  Register Sentry's ErrorSubscriber for Rails 7.0+ apps (getsentry#1705)
  Support serializing ActiveRecord job arguments in global id form (getsentry#1688)
  release: 5.0.2
  Fix report_after_job_retries's decision logic (getsentry#1704)
  Followup of getsentry#1701 (getsentry#1703)
  Capture transaction tags (getsentry#1701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync span operation names
4 participants