Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence method redefined warnings #1513

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jul 24, 2021

This is a continuation of #1504

@st0012 st0012 added this to the 4.7.0 milestone Jul 24, 2021
@st0012 st0012 self-assigned this Jul 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2021

Codecov Report

Merging #1513 (86f9056) into master (02401e9) will increase coverage by 0.55%.
The diff coverage is 100.00%.

❗ Current head 86f9056 differs from pull request most recent head a5cb12b. Consider uploading reports for the commit a5cb12b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   98.19%   98.75%   +0.55%     
==========================================
  Files         218      123      -95     
  Lines       10597     6761    -3836     
==========================================
- Hits        10406     6677    -3729     
+ Misses        191       84     -107     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/core_ext/object/deep_dup.rb 94.11% <100.00%> (ø)
...ntry-ruby/lib/sentry/core_ext/object/duplicable.rb 70.21% <100.00%> (ø)
sentry-ruby/lib/sentry/event.rb 100.00% <100.00%> (+1.23%) ⬆️
sentry-ruby/lib/sentry/transaction_event.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb 97.05% <0.00%> (-0.09%) ⬇️
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <0.00%> (ø)
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb 100.00% <0.00%> (ø)
sentry-raven/lib/raven/processor/utf8conversion.rb
...lib/raven/integrations/rails/controller_methods.rb
...ntry-raven/lib/raven/processor/removestacktrace.rb
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02401e9...a5cb12b. Read the comment docs.

@st0012 st0012 merged commit c90e5cc into master Jul 26, 2021
@st0012 st0012 deleted the silent-method-redefined-warnings branch July 26, 2021 01:34
@st0012 st0012 modified the milestones: 4.7.0, 4.6.3 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants