-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence some ruby warnings #1504
Conversation
Sending to review without green CI due to Also not sure if changelog here is needed and which |
8386c50
to
dd1c32c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
+ Coverage 98.19% 98.74% +0.54%
==========================================
Files 218 123 -95
Lines 10598 6760 -3838
==========================================
- Hits 10407 6675 -3732
+ Misses 191 85 -106
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍
The changes generally look good but I want to cleanup Event
and TransactionEvent
's attributes myself. Can you exclude them?
And regarding changeslog, can you update the top-level one? thanks.
dd1c32c
to
0adc8d0
Compare
Done. Any ETA on this or GH issue that I could follow? |
after(:all) do | ||
Net.send(:const_set, :BufferedIO, original_buffered_io) | ||
end | ||
before { stub_const('Net::BufferedIO', Net::WebMockNetBufferedIO) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'll add a PR for that in a week and include an changelog entry for this PR as well. |
Ugh, I have CHANGELOG entry locally, but it's not committed 🤦 |
I've added #1513 as a continuation of the work. |
Description
Describe your changes:
Not sure if we should
undef_method
or just not define our variants. As a corporation you probably wantundef_method
for extra-defined behavior.Also could add warning gem to devdeps and enforce no-warnings via CI if desired.