chore(ci): Fix update-deps failure #4749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bda0cc+dirty | 1221.90 ms | 1208.11 ms | -13.79 ms |
| b6da94a+dirty | 1227.82 ms | 1238.86 ms | 11.04 ms |
| d997097+dirty | 1231.90 ms | 1236.80 ms | 4.90 ms |
| e652a2e+dirty | 1221.86 ms | 1219.79 ms | -2.07 ms |
| 9f0f6c8+dirty | 1231.60 ms | 1232.73 ms | 1.12 ms |
| a0df630+dirty | 1222.02 ms | 1219.10 ms | -2.92 ms |
| bab7feb+dirty | 1233.88 ms | 1236.65 ms | 2.78 ms |
| e22745e+dirty | 1222.73 ms | 1224.98 ms | 2.25 ms |
| e1ea4a8+dirty | 1233.49 ms | 1237.71 ms | 4.22 ms |
| baad1d9+dirty | 1228.38 ms | 1231.39 ms | 3.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bda0cc+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| b6da94a+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
| d997097+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| e652a2e+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| 9f0f6c8+dirty | 2.36 MiB | 3.10 MiB | 759.48 KiB |
| a0df630+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| bab7feb+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| e22745e+dirty | 2.36 MiB | 3.10 MiB | 752.32 KiB |
| e1ea4a8+dirty | 2.36 MiB | 3.10 MiB | 752.31 KiB |
| baad1d9+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bec795 | 437.23 ms | 428.21 ms | -9.02 ms |
| 5a22220 | 412.38 ms | 447.35 ms | 34.97 ms |
| 9c48b2c | 349.24 ms | 385.96 ms | 36.72 ms |
| a18210a | 455.15 ms | 530.29 ms | 75.15 ms |
| 484813b | 434.55 ms | 452.31 ms | 17.75 ms |
| 7e87527 | 425.56 ms | 407.64 ms | -17.93 ms |
| 5571a20 | 410.55 ms | 441.06 ms | 30.51 ms |
| ae7b03d | 428.82 ms | 412.33 ms | -16.49 ms |
| 10e6a21 | 377.96 ms | 406.04 ms | 28.08 ms |
| cdc3945 | 422.77 ms | 438.19 ms | 15.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bec795 | 17.75 MiB | 20.13 MiB | 2.38 MiB |
| 5a22220 | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| 9c48b2c | 17.73 MiB | 19.80 MiB | 2.07 MiB |
| a18210a | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 484813b | 17.73 MiB | 20.07 MiB | 2.33 MiB |
| 7e87527 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 5571a20 | 17.73 MiB | 19.93 MiB | 2.19 MiB |
| ae7b03d | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 10e6a21 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| cdc3945 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bda0cc+dirty | 1217.90 ms | 1223.02 ms | 5.12 ms |
| b6da94a+dirty | 1219.33 ms | 1223.35 ms | 4.02 ms |
| d997097+dirty | 1223.29 ms | 1229.76 ms | 6.46 ms |
| e652a2e+dirty | 1224.76 ms | 1218.86 ms | -5.90 ms |
| 9f0f6c8+dirty | 1236.94 ms | 1245.41 ms | 8.47 ms |
| a0df630+dirty | 1211.12 ms | 1216.02 ms | 4.90 ms |
| bab7feb+dirty | 1218.80 ms | 1220.57 ms | 1.78 ms |
| e22745e+dirty | 1246.02 ms | 1233.60 ms | -12.42 ms |
| e1ea4a8+dirty | 1228.98 ms | 1222.80 ms | -6.18 ms |
| baad1d9+dirty | 1251.59 ms | 1245.84 ms | -5.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bda0cc+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| b6da94a+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
| d997097+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| e652a2e+dirty | 3.19 MiB | 4.31 MiB | 1.12 MiB |
| 9f0f6c8+dirty | 2.92 MiB | 3.67 MiB | 771.98 KiB |
| a0df630+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| bab7feb+dirty | 3.19 MiB | 4.31 MiB | 1.12 MiB |
| e22745e+dirty | 2.92 MiB | 3.66 MiB | 756.73 KiB |
| e1ea4a8+dirty | 2.92 MiB | 3.66 MiB | 756.65 KiB |
| baad1d9+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60d62c2+dirty | 324.10 ms | 331.00 ms | 6.90 ms |
| 13f280b+dirty | 376.13 ms | 406.41 ms | 30.28 ms |
| c639edf+dirty | 363.39 ms | 414.78 ms | 51.39 ms |
| 7d161c0+dirty | 383.35 ms | 398.73 ms | 15.38 ms |
| baad1d9+dirty | 379.27 ms | 385.51 ms | 6.24 ms |
| 79976dd+dirty | 373.25 ms | 404.64 ms | 31.39 ms |
| a15d370+dirty | 376.25 ms | 388.17 ms | 11.92 ms |
| 0eacc98+dirty | 393.31 ms | 445.21 ms | 51.90 ms |
| 8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
| 5e5c392+dirty | 360.23 ms | 347.88 ms | -12.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60d62c2+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 13f280b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| c639edf+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 7d161c0+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| baad1d9+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 79976dd+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| a15d370+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 0eacc98+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
| 5e5c392+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| @@ -1,6 +1,6 @@ | |||
| # expects `$repo`, `$tagPrefix` and `$packages` (array) variables to be defined, see e.g. update-javascript.sh | |||
|
|
|||
| npm i -g corepack # This repository uses Yarn v3 which requires corepack to be installed | |||
| corepack enable # This repository uses Yarn v3 which requires corepack to be enabled | |||
There was a problem hiding this comment.
Let's add a comment with a brief explanation that this will need to be fixed in the future and why and link to the original PR.
There was a problem hiding this comment.
Good idea Krystof 👍
Added a comment with 51ac355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Reverts the
scripts/update-package-json.shchange introduced by #4741 and just runs 'corepack enable' without globally installing. Also tested enabling after install with 38214b6 but the failure persisted.💡 Motivation and Context
CI failures on main after merging the above PR 950b04f
💚 How did you test it?
CI (run) by temporarily enabling the job for PRs
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
Figure out why the update-deps fail with the global installation (e.g. a version mismatch 🤔)
#skip-changelog