feat(feedback): Screenshot button #4714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
This was referenced Apr 9, 2025
antonis
commented
Apr 14, 2025
| @@ -8,20 +8,23 @@ import { defaultScreenshotButtonConfiguration } from './defaults'; | |||
| import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles'; | |||
| import { getTheme } from './FeedbackWidget.theme'; | |||
| import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types'; | |||
| import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager'; | |||
There was a problem hiding this comment.
The cyclic dep failure is fixed in #4718
# Conflicts: # CHANGELOG.md # packages/core/src/js/feedback/FeedbackWidget.styles.ts # packages/core/src/js/feedback/FeedbackWidgetManager.tsx # packages/core/src/js/feedback/integration.ts # packages/core/test/feedback/FeedbackWidgetManager.test.tsx
| @@ -180,6 +180,11 @@ describe('ScreenshotButton', () => { | |||
| const takeScreenshotButtonAfterCapture = queryByText('Take a screenshot'); | |||
| expect(takeScreenshotButtonAfterCapture).toBeNull(); | |||
| }); | |||
|
|
|||
| await waitFor(() => { | |||
| const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot'); | |||
There was a problem hiding this comment.
L: Just fixed the name and double negation not null.
Suggested change
| const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot'); | |
| const removeScreenshotButtonAfterCapture = queryByText('Remove screenshot'); | |
| expect(removeScreenshotButtonAfterCapture).toBeTruthy(); |
There was a problem hiding this comment.
Good catch Krystof 🙇
Updated with 59597a4
krystofwoldrich
approved these changes
Apr 14, 2025
10 tasks
6 tasks
antonis
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - #13512 - #13513 - 👉 #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds screenshot button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4714 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - #13512 - #13513 - 👉 #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds screenshot button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4714 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Based on feat(feedback): Theming
PR Chain:
📜 Description
take screenshot buttonin the feedback widget that:screenshot buttonscreenshot buttonthat captures a screenshot and opens the feedback widget modal with the captured screenshot as attachmentcaptureScreenshot()function is only available on mobile. Support for web environment will be investigated on a separate PR.Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot(orimagePickerset)enableTakeScreenshot💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps