Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add network breadcrumbs #3912

Merged
merged 42 commits into from
Jun 27, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jun 24, 2024

📢 Type of change

  • New feature

📜 Description

This PR adds network breadcrumbs to RN replays.

💚 How did you test it?

RN sample app, Android works, iOS waiting for #3846, iOS working

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Screenshot 2024-06-24 at 16 36 58

Screenshot 2024-06-25 at 10 59 14

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2b5a2f4

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.38 ms 470.43 ms 38.05 ms
Size 7.15 MiB 8.31 MiB 1.17 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d+dirty 374.57 ms 415.25 ms 40.68 ms

App size

Revision Plain With Sentry Diff
41db11d+dirty 7.15 MiB 8.31 MiB 1.16 MiB

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 420.07 ms 475.61 ms 55.54 ms
Size 17.73 MiB 20.04 MiB 2.30 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d 429.33 ms 451.24 ms 21.91 ms

App size

Revision Plain With Sentry Diff
41db11d 17.73 MiB 20.04 MiB 2.30 MiB

@krystofwoldrich krystofwoldrich changed the title Kw/add-replay-network-breadcrumb feat(replay): Add network breadcrumbs Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jun 26, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.54 ms 1215.66 ms -2.88 ms
Size 2.36 MiB 3.05 MiB 702.80 KiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d+dirty 1207.36 ms 1210.32 ms 2.96 ms

App size

Revision Plain With Sentry Diff
41db11d+dirty 2.36 MiB 3.04 MiB 698.69 KiB

Copy link
Contributor

github-actions bot commented Jun 26, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1244.31 ms 1241.37 ms -2.94 ms
Size 2.92 MiB 3.61 MiB 709.96 KiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d+dirty 1208.60 ms 1210.47 ms 1.87 ms

App size

Revision Plain With Sentry Diff
41db11d+dirty 2.92 MiB 3.61 MiB 705.84 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review June 26, 2024 10:47
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are some conflicts with what I've done today in the base PR.

src/js/replay/networkUtils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feat/replay-breadcrumbs to feat/replay June 26, 2024 14:55
krystofwoldrich and others added 4 commits June 27, 2024 15:55
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
@krystofwoldrich krystofwoldrich merged commit ac72abc into feat/replay Jun 27, 2024
52 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/add-replay-network-breadcrumb branch June 27, 2024 14:45
bruno-garcia added a commit that referenced this pull request Jul 15, 2024
* feat(replay): Add Mobile Replay Alpha (#3714)

* feat(sample): add running indicator (animation overlay) (#3903)

* feat(replay): Add breadcrumbs mapping from RN to RRWeb format (#3846)

* feat(replay): Add network breadcrumbs (#3912)

* fix(replay): Add tests for touch events (#3924)

* feat(replay): Filter Sentry event breadcrumbs (#3925)

* fix(changelog): Add latest native SDKs details

* release: 5.25.0-alpha.2

* misc(samples): Add console anything examples for replay testing (#3928)

* feat: Add Sentry Babel Transformer (#3916)

* fix(replay): Add app lifecycle breadcrumbs conversion tests (#3932)

* chore(deps): bump sentry-android to 7.12.0-alpha.3

* chore(deps): bump sentry-android to 7.12.0-alpha.4

* fix(replay): Mask SVGs from `react-native-svg` when `maskAllVectors=true` (#3930)

* fix(replay): Add missing properties to android nav breadcrumbs (#3942)

* release: 5.26.0-alpha.3

* misc(replay): Add Mobile Replay Public Beta changelog (#3943)

---------

Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Co-authored-by: Ivan Dlugos <dlugos.ivan@gmail.com>
Co-authored-by: getsentry-bot <bot@sentry.io>
Co-authored-by: getsentry-bot <bot@getsentry.com>
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants