Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Sentry Opentelemetry support #2979

Closed
wants to merge 1 commit into from
Closed

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • New feature

📜 Description

This is an example of how Sentry Otel integration could be used in RN JS layer.

💡 Motivation and Context

💚 How did you test it?

Sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Sentry Opentelemetry support ([#2979](https://github.com/getsentry/sentry-react-native/pull/2979))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 584c33f

@marandaneto marandaneto marked this pull request as draft April 18, 2023 11:23
@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 340.50 ms 343.76 ms 3.26 ms
Size 17.73 MiB 19.75 MiB 2.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1295.66 ms 1300.80 ms 5.14 ms
Size 2.36 MiB 2.84 MiB 487.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms

App size

Revision Plain With Sentry Diff
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 269.14 ms 313.57 ms 44.43 ms
Size 7.15 MiB 8.04 MiB 912.27 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms

App size

Revision Plain With Sentry Diff
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB

@krystofwoldrich
Copy link
Member Author

This POC was working, but as the support for Otel was experimental at the time a lot changed since then.

Therefore the PR is not up to date anymore.

@krystofwoldrich krystofwoldrich deleted the kw-otel-example branch October 4, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants