Skip to content

ref(clickhouse): List send_data parameters #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szokeasaurusrex
Copy link
Member

Explicitly list the send_data parameters in the wrapped function. The parameters are coming from here. Continue also providing *args and **kwargs, but only for forwards-compatibility.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval.

Explicitly list the `send_data` parameters in the wrapped function. The parameters are coming from [here](https://github.com/mymarilyn/clickhouse-driver/blob/8a4e7c5b99b532df2b015651d893a6f36288a22c/clickhouse_driver/client.py#L634). Continue also providing `*args` and `**kwargs`, but only for forwards-compatibility.
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner August 4, 2025 14:57
@szokeasaurusrex szokeasaurusrex requested review from sentrivana and removed request for a team August 4, 2025 14:57
Copy link

codecov bot commented Aug 4, 2025

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
23744 9 23735 2289
View the top 3 failed test(s) by shortest run time
tests.integrations.clickhouse_driver.test_clickhouse_driver::test_clickhouse_dbapi_breadcrumbs_with_pii
Stack Traces | 0.054s run time
.../integrations/clickhouse_driver/test_clickhouse_driver.py:573: in test_clickhouse_dbapi_breadcrumbs_with_pii
    send_default_pii=True,
tests/conftest.py:209: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:284: in __init__
    self._init_impl()
sentry_sdk/client.py:420: in _init_impl
    disabled_integrations=self.options["disabled_integrations"],
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    type(integration).setup_once()
sentry_sdk/integrations/clickhouse_driver.py:53: in setup_once
    _wrap_send_data()
sentry_sdk/integrations/clickhouse_driver.py:138: in _wrap_send_data
    columnar: bool = False,
E   TypeError: unsupported operand type(s) for |: 'type' and 'type'
tests.integrations.clickhouse_driver.test_clickhouse_driver::test_clickhouse_dbapi_spans
Stack Traces | 0.055s run time
.../integrations/clickhouse_driver/test_clickhouse_driver.py:677: in test_clickhouse_dbapi_spans
    traces_sample_rate=1.0,
tests/conftest.py:209: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:284: in __init__
    self._init_impl()
sentry_sdk/client.py:420: in _init_impl
    disabled_integrations=self.options["disabled_integrations"],
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    type(integration).setup_once()
sentry_sdk/integrations/clickhouse_driver.py:53: in setup_once
    _wrap_send_data()
sentry_sdk/integrations/clickhouse_driver.py:138: in _wrap_send_data
    columnar: bool = False,
E   TypeError: unsupported operand type(s) for |: 'type' and 'type'
tests.integrations.clickhouse_driver.test_clickhouse_driver::test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0.055s run time
.../integrations/clickhouse_driver/test_clickhouse_driver.py:800: in test_clickhouse_dbapi_spans_with_pii
    send_default_pii=True,
tests/conftest.py:209: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:284: in __init__
    self._init_impl()
sentry_sdk/client.py:420: in _init_impl
    disabled_integrations=self.options["disabled_integrations"],
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    type(integration).setup_once()
sentry_sdk/integrations/clickhouse_driver.py:53: in setup_once
    _wrap_send_data()
sentry_sdk/integrations/clickhouse_driver.py:138: in _wrap_send_data
    columnar: bool = False,
E   TypeError: unsupported operand type(s) for |: 'type' and 'type'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant