Skip to content

feat(logs): Add support for dict args #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

feat(logs): Add support for dict args #4478

merged 1 commit into from
Jun 16, 2025

Conversation

AbhiPrasad
Copy link
Member

resolves #4477

This PR adds support for dict log arguments and adds (cursor generated) tests accordingly.

@AbhiPrasad AbhiPrasad self-assigned this Jun 16, 2025
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner June 16, 2025 13:47
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.64%. Comparing base (0e21fa2) to head (d4714bb).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/logging.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4478      +/-   ##
==========================================
+ Coverage   80.59%   80.64%   +0.04%     
==========================================
  Files         142      142              
  Lines       16030    16033       +3     
  Branches     2745     2747       +2     
==========================================
+ Hits        12920    12930      +10     
+ Misses       2243     2236       -7     
  Partials      867      867              
Files with missing lines Coverage Δ
sentry_sdk/integrations/logging.py 83.97% <66.66%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AbhiPrasad AbhiPrasad merged commit f71d223 into master Jun 16, 2025
136 of 137 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-dict-args branch June 16, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support named arguments in with logging integration
2 participants