Skip to content

chore(ourlogs): Use new transport #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

chore(ourlogs): Use new transport #4317

merged 3 commits into from
Apr 29, 2025

Conversation

colin-sentry
Copy link
Member

@colin-sentry colin-sentry commented Apr 17, 2025

We've added a more efficient transport for logs handling, use that.

Solves LOGS-60

@colin-sentry colin-sentry requested a review from a team as a code owner April 17, 2025 19:44
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (f3687fc) to head (48e40d4).
Report is 16 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/_log_batcher.py 84.21% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4317      +/-   ##
==========================================
- Coverage   80.30%   80.30%   -0.01%     
==========================================
  Files         142      142              
  Lines       15925    15924       -1     
  Branches     2724     2725       +1     
==========================================
- Hits        12789    12787       -2     
  Misses       2262     2262              
- Partials      874      875       +1     
Files with missing lines Coverage Δ
sentry_sdk/envelope.py 82.35% <100.00%> (-0.18%) ⬇️
sentry_sdk/_log_batcher.py 75.29% <84.21%> (-0.90%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colin-sentry colin-sentry merged commit 7f01372 into master Apr 29, 2025
141 checks passed
@colin-sentry colin-sentry deleted the ourlog_new_transport branch April 29, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants