Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove pytest pin in requirements-devenv.txt #3696

Merged

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Oct 28, 2024

The pytest pin in requirements-devenv.txt appears to be unnecessary. Our tests anyways do not seem to respect this pin; the actual pins are defined for each environment in tox.ini.

ref #3035

without changing any tests
Copy link

codecov bot commented Oct 28, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13593 1 13592 4114
View the top 1 failed tests by shortest run time
tests.integrations.httpx.test_httpx test_omit_url_data_if_parsing_fails
Stack Traces | 5.12s run time
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpx/_transports/default.py:72: in map_httpcore_exceptions
    yield
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpx/_transports/default.py:236: in handle_request
    resp = self._pool.handle_request(req)
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpcore/_sync/connection_pool.py:216: in handle_request
    raise exc from None
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpcore/_sync/connection_pool.py:196: in handle_request
    response = connection.handle_request(
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpcore/_sync/connection.py:99: in handle_request
    raise exc
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpcore/_sync/connection.py:76: in handle_request
    stream = self._connect(request)
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpcore/_sync/connection.py:122: in _connect
    stream = self._network_backend.connect_tcp(**kwargs)
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpcore/_backends/sync.py:205: in connect_tcp
    with map_exceptions(exc_map):
.../hostedtoolcache/Python/3.11.10....../x64/lib/python3.11/contextlib.py:158: in __exit__
    self.gen.throw(typ, value, traceback)
.tox/py3.11-httpx-v0.27/lib/python3.11.../site-packages/httpcore/_exceptions.py:14: in map_exceptions
    raise to_exc(exc) from exc
E   httpcore.ConnectError: [Errno 101] Network is unreachable

The above exception was the direct cause of the following exception:
.../integrations/httpx/test_httpx.py:305: in test_omit_url_data_if_parsing_fails
    response = httpx_client.get(url)
.tox/py3.11-httpx-v0.27/lib/python3.11................../site-packages/httpx/_client.py:1066: in get
    return self.request(
.tox/py3.11-httpx-v0.27/lib/python3.11................../site-packages/httpx/_client.py:837: in request
    return self.send(request, auth=auth, follow_redirects=follow_redirects)
sentry_sdk/utils.py:1788: in runner
    return sentry_patched_function(*args, **kwargs)
sentry_sdk/integrations/httpx.py:87: in send
    rv = real_send(self, request, **kwargs)
.tox/py3.11-httpx-v0.27/lib/python3.11................../site-packages/httpx/_client.py:926: in send
    response = self._send_handling_auth(
.tox/py3.11-httpx-v0.27/lib/python3.11................../site-packages/httpx/_client.py:954: in _send_handling_auth
    response = self._send_handling_redirects(
.tox/py3.11-httpx-v0.27/lib/python3.11................../site-packages/httpx/_client.py:991: in _send_handling_redirects
    response = self._send_single_request(request)
.tox/py3.11-httpx-v0.27/lib/python3.11................../site-packages/httpx/_client.py:1027: in _send_single_request
    response = transport.handle_request(request)
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpx/_transports/default.py:235: in handle_request
    with map_httpcore_exceptions():
.../hostedtoolcache/Python/3.11.10....../x64/lib/python3.11/contextlib.py:158: in __exit__
    self.gen.throw(typ, value, traceback)
.tox/py3.11-httpx-v0.27/lib/python3.11.../httpx/_transports/default.py:89: in map_httpcore_exceptions
    raise mapped_exc(message) from exc
E   httpx.ConnectError: [Errno 101] Network is unreachable

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@szokeasaurusrex szokeasaurusrex changed the title test unpinning pytest without changing any tests build: Remove pytest pin in requirements-devenv.txt Oct 28, 2024
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review October 28, 2024 11:37
@szokeasaurusrex szokeasaurusrex merged commit 483a0bd into master Oct 28, 2024
136 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/test-unpin-pytest-no-test-change branch October 28, 2024 12:36
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants