-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort breadcrumbs before sending #3307
Conversation
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 15978 tests with View the full list of failed testspy3.10-common
py3.10-gevent
py3.6-common
py3.6-gevent
py3.7-common
py3.8-common
py3.8-gevent
py3.9-common
|
…ntry-python into antonpirker/fix-breadcrumbs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change lgtm. Can we also have a test for this or is it a pita?
I'll check |
Now with test @sentrivana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, ty!
Make sure our breadcrumbs are sorted by timestamp before sending to Sentry. Fixes getsentry#3306
Make sure our breadcrumbs are sorted by timestamp before sending to Sentry.
Fixes #3306