Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved should_send_default_pii into client #2840

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Moved should_send_default_pii into client #2840

merged 2 commits into from
Mar 18, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Mar 18, 2024 •
edited
Loading

Moved functionality from _should_send_default_pii() in Hub into should_send_default_pii on the Client.

Fixes #2819

@antonpirker antonpirker changed the base branch from master to sentry-sdk-2.0 March 18, 2024 14:00
szokeasaurusrex
szokeasaurusrex approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment to the old _should_send_default_pii so we remember not to use it going forward

@antonpirker antonpirker merged commit 0a47317 into sentry-sdk-2.0 Mar 18, 2024
15 checks passed
@antonpirker antonpirker deleted the antonpirker/moved-should-send-default-pii-to-client branch March 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK 2.0] Fix Client should_send_default_pii implementation
2 participants
@antonpirker @szokeasaurusrex