Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(gql): Use new scopes API in GQL Integration #2838

Merged
merged 26 commits into from
Mar 19, 2024
Merged

ref(gql): Use new scopes API in GQL Integration #2838

merged 26 commits into from
Mar 19, 2024

Conversation

szokeasaurusrex
Copy link
Member

No description provided.

@szokeasaurusrex
Created async and sync decorators
190923c
@szokeasaurusrex
Added use of each sentry decorator
c8aeadb
@szokeasaurusrex
Fix circular import
c18a902
@szokeasaurusrex
Merge branch 'sentry-sdk-2.0' into szokeasaurusrex/sentry_patched_dec…
0fbea43 
…orator
@szokeasaurusrex
Revert changes to starlette.py
9f5c279
@szokeasaurusrex
Rename method
45b90ab
@szokeasaurusrex
Use actual generics, move async implementation to utils
69ebafb
@szokeasaurusrex
Refactor parameters
46cd0e2
@szokeasaurusrex
Undo changes to _types.py
7a8196a
@szokeasaurusrex
Use client instead of Hub
d9016db
@szokeasaurusrex
Add doc string
75934d1
@szokeasaurusrex
Move type comments
66726d0
@szokeasaurusrex
Merge branch 'sentry-sdk-2.0' into szokeasaurusrex/sentry_patched_dec…
4e48ce3 
…orator
@szokeasaurusrex
Fix mypy
e8c921c
@szokeasaurusrex
Fix circular import
20688fd
@szokeasaurusrex
Added unit tests for decorators
d93ff92
@szokeasaurusrex
Merge branch 'sentry-sdk-2.0' into szokeasaurusrex/sentry_patched_dec…
4b90191 
…orator
@szokeasaurusrex
Revert gql changes
85c1a1f
@szokeasaurusrex
Revert "Revert gql changes"
682eb71 
This reverts commit 85c1a1f.
@szokeasaurusrex szokeasaurusrex self-assigned this Mar 18, 2024
@szokeasaurusrex szokeasaurusrex mentioned this pull request Mar 18, 2024
Closed
@szokeasaurusrex szokeasaurusrex removed their assignment Mar 18, 2024
Base automatically changed from szokeasaurusrex/sentry_patched_decorator to sentry-sdk-2.0 March 19, 2024 08:54
@szokeasaurusrex szokeasaurusrex self-assigned this Mar 19, 2024
@szokeasaurusrex szokeasaurusrex changed the title WIP: Use new scopes API in GQL Integration ref(gql): Use new scopes API in GQL Integration Mar 19, 2024
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review March 19, 2024 10:48
antonpirker
antonpirker requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When possible we should always use sentry_sdk.* to call the top level apis, because then you always get the right scope or client.

sentry_sdk/integrations/gql.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/gql.py Show resolved Hide resolved
antonpirker
antonpirker approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@szokeasaurusrex szokeasaurusrex merged commit 37d07f0 into sentry-sdk-2.0 Mar 19, 2024
111 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/gql-new-scope-api branch March 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szokeasaurusrex @antonpirker