Revert "Pin urllib3 to <2.0.0 for now" #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d301bb.
asottile-sentry
force-pushed
the
revert-2069-neel/pin-urllib
branch
2 times, most recently
from
b3c794b to
ef6a269
Compare
asottile-sentry
force-pushed
the
revert-2069-neel/pin-urllib
branch
from
ef6a269 to
1f9b47e
Compare
asottile-sentry
requested review from
adinauer,
antonpirker and
sl0thentr0py
and removed request for
adinauer
Member
|
there is more complexity to the discussion and an open PR at #2137 |
Contributor
Author
|
that PR is based on an incorrect assumption and does not include the necessary fixes to typing, docs, etc. |
sentrivana
requested changes
Jun 1, 2023
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
See comment, otherwise LGTM.
sentrivana
approved these changes
Jun 2, 2023
sentrivana
pushed a commit
that referenced
this pull request
Jun 5, 2023
This reverts commit 0d301bb.
nijel
added a commit
to WeblateOrg/weblate
that referenced
this pull request
Jul 29, 2023
We need getsentry/sentry-python#2148 included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2069
Resolves #2070
this shouldn't have been pinned in the first place. the actual failure was unrelated to sentry. they should have pinned in their app -- a library should not make this decision for its users