Skip to content

Conversation

@rcmarron
Copy link
Contributor

Problem

This updates the type of the functions_to_trace param to match the latest changes.

The expected format introduced here is:

functions_to_trace = [
    {"qualified_name": "tests.test_basics._hello_world_counter"},
    {"qualified_name": "time.sleep"},
    {"qualified_name": "collections.Counter.most_common"},
]

But the current type is List[str]

@rcmarron
Copy link
Contributor Author

cc @antonpirker, I think this is your domain.

@sentrivana
Copy link
Contributor

Thanks for spotting this and fixing it, @rcmarron! It's also wrong in the docs, I'll push a fix.

@sentrivana sentrivana enabled auto-merge (squash) May 25, 2023 12:37
@sentrivana sentrivana merged commit 72f1e92 into getsentry:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants