Skip to content

Commit dd294be

Browse files
authored
ref(perf-issues): Increase max string size for desc (#1647)
Our python sdk is the only sdk which sends truncated desc from the sdk side. This effects our ability to cleanly detect perf issues, but in general we should probably aim for more consistency. This bumps the max limit by a moderate amount (again, other sdk's are already sending unbounded data).
1 parent 0929871 commit dd294be

File tree

6 files changed

+20
-20
lines changed

6 files changed

+20
-20
lines changed

sentry_sdk/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
# The logger is created here but initialized in the debug support module
4141
logger = logging.getLogger("sentry_sdk.errors")
4242

43-
MAX_STRING_LENGTH = 512
43+
MAX_STRING_LENGTH = 1024
4444
BASE64_ALPHABET = re.compile(r"^[a-zA-Z0-9/+=]*$")
4545

4646

tests/integrations/bottle/test_bottle.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ def index():
150150

151151
(event,) = events
152152
assert event["_meta"]["request"]["data"]["foo"]["bar"] == {
153-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
153+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
154154
}
155-
assert len(event["request"]["data"]["foo"]["bar"]) == 512
155+
assert len(event["request"]["data"]["foo"]["bar"]) == 1024
156156

157157

158158
@pytest.mark.parametrize("data", [{}, []], ids=["empty-dict", "empty-list"])
@@ -200,9 +200,9 @@ def index():
200200

201201
(event,) = events
202202
assert event["_meta"]["request"]["data"]["foo"] == {
203-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
203+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
204204
}
205-
assert len(event["request"]["data"]["foo"]) == 512
205+
assert len(event["request"]["data"]["foo"]) == 1024
206206

207207

208208
@pytest.mark.parametrize("input_char", ["a", b"a"])
@@ -265,9 +265,9 @@ def index():
265265

266266
(event,) = events
267267
assert event["_meta"]["request"]["data"]["foo"] == {
268-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
268+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
269269
}
270-
assert len(event["request"]["data"]["foo"]) == 512
270+
assert len(event["request"]["data"]["foo"]) == 1024
271271

272272
assert event["_meta"]["request"]["data"]["file"] == {
273273
"": {

tests/integrations/falcon/test_falcon.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,9 @@ def on_post(self, req, resp):
207207

208208
(event,) = events
209209
assert event["_meta"]["request"]["data"]["foo"]["bar"] == {
210-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
210+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
211211
}
212-
assert len(event["request"]["data"]["foo"]["bar"]) == 512
212+
assert len(event["request"]["data"]["foo"]["bar"]) == 1024
213213

214214

215215
@pytest.mark.parametrize("data", [{}, []], ids=["empty-dict", "empty-list"])

tests/integrations/flask/test_flask.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,9 +263,9 @@ def index():
263263

264264
(event,) = events
265265
assert event["_meta"]["request"]["data"]["foo"]["bar"] == {
266-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
266+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
267267
}
268-
assert len(event["request"]["data"]["foo"]["bar"]) == 512
268+
assert len(event["request"]["data"]["foo"]["bar"]) == 1024
269269

270270

271271
def test_flask_session_tracking(sentry_init, capture_envelopes, app):
@@ -352,9 +352,9 @@ def index():
352352

353353
(event,) = events
354354
assert event["_meta"]["request"]["data"]["foo"] == {
355-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
355+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
356356
}
357-
assert len(event["request"]["data"]["foo"]) == 512
357+
assert len(event["request"]["data"]["foo"]) == 1024
358358

359359

360360
def test_flask_formdata_request_appear_transaction_body(
@@ -441,9 +441,9 @@ def index():
441441

442442
(event,) = events
443443
assert event["_meta"]["request"]["data"]["foo"] == {
444-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
444+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
445445
}
446-
assert len(event["request"]["data"]["foo"]) == 512
446+
assert len(event["request"]["data"]["foo"]) == 1024
447447

448448
assert event["_meta"]["request"]["data"]["file"] == {
449449
"": {"len": 0, "rem": [["!raw", "x", 0, 0]]}

tests/integrations/pyramid/test_pyramid.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,9 @@ def index(request):
165165

166166
(event,) = events
167167
assert event["_meta"]["request"]["data"]["foo"]["bar"] == {
168-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
168+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
169169
}
170-
assert len(event["request"]["data"]["foo"]["bar"]) == 512
170+
assert len(event["request"]["data"]["foo"]["bar"]) == 1024
171171

172172

173173
@pytest.mark.parametrize("data", [{}, []], ids=["empty-dict", "empty-list"])
@@ -209,9 +209,9 @@ def index(request):
209209

210210
(event,) = events
211211
assert event["_meta"]["request"]["data"]["foo"] == {
212-
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
212+
"": {"len": 2000, "rem": [["!limit", "x", 1021, 1024]]}
213213
}
214-
assert len(event["request"]["data"]["foo"]) == 512
214+
assert len(event["request"]["data"]["foo"]) == 1024
215215

216216
assert event["_meta"]["request"]["data"]["file"] == {
217217
"": {"len": 0, "rem": [["!raw", "x", 0, 0]]}

tests/integrations/sqlalchemy/test_sqlalchemy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,5 +214,5 @@ def processor(event, hint):
214214

215215
# The _meta for other truncated fields should be there as well.
216216
assert event["_meta"]["message"] == {
217-
"": {"len": 522, "rem": [["!limit", "x", 509, 512]]}
217+
"": {"len": 1034, "rem": [["!limit", "x", 1021, 1024]]}
218218
}

0 commit comments

Comments
 (0)