fix: Fix list attribute type (#5417)

List attributes should be sent over the wire with `type: array` instead
of specialized `integer[]`, `string[]` etc. types.

We might support non-homogenous arrays in the future.

Author: sentrivana

sentry_sdk/_types.py

@@ -241,10 +241,7 @@ class SDKInfo(TypedDict):
                 "boolean",
                 "double",
                 "integer",
-                "string[]",
-                "boolean[]",
-                "double[]",
-                "integer[]",
+                "array",
             ],
             "value": AttributeValue,
         },

sentry_sdk/utils.py

@@ -2097,19 +2097,12 @@ def serialize_attribute(val: "AttributeValue") -> "SerializedAttributeValue":
 
     if isinstance(val, list):
         if not val:
-            return {"value": [], "type": "string[]"}
+            return {"value": [], "type": "array"}
 
         # Only lists of elements of a single type are supported
-        list_types: 'dict[type, Literal["string[]", "integer[]", "double[]", "boolean[]"]]' = {
-            str: "string[]",
-            int: "integer[]",
-            float: "double[]",
-            bool: "boolean[]",
-        }
-
         ty = type(val[0])
-        if ty in list_types and all(type(v) is ty for v in val):
-            return {"value": val, "type": list_types[ty]}
+        if ty in (int, str, bool, float) and all(type(v) is ty for v in val):
+            return {"value": val, "type": "array"}
 
     # Coerce to string if we don't know what to do with the value. This should
     # never happen as we pre-format early in format_attribute, but let's be safe.

tests/test_logs.py

@@ -692,11 +692,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):
 
     assert serialized_attributes["string_list"] == {
         "value": ["value1", "value2"],
-        "type": "string[]",
+        "type": "array",
     }
     assert serialized_attributes["int_tuple"] == {
         "value": [3, 2, 1, 4],
-        "type": "integer[]",
+        "type": "array",
     }
     assert serialized_attributes["inhomogeneous_tuple"] == {
         "value": "(3, 2.0, 1, 4)",
@@ -705,11 +705,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):
 
     assert serialized_attributes["float_list"] == {
         "value": [3.0, 3.5, 4.2],
-        "type": "double[]",
+        "type": "array",
     }
     assert serialized_attributes["bool_tuple"] == {
         "value": [False, False, True],
-        "type": "boolean[]",
+        "type": "array",
     }
     assert serialized_attributes["inhomogeneous_list"] == {
         "value": "[3.2, True, None]",

tests/test_metrics.py

@@ -425,11 +425,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):
 
     assert serialized_attributes["string_list.attribute"] == {
         "value": ["value1", "value2"],
-        "type": "string[]",
+        "type": "array",
     }
     assert serialized_attributes["int_tuple.attribute"] == {
         "value": [3, 2, 1, 4],
-        "type": "integer[]",
+        "type": "array",
     }
     assert serialized_attributes["inhomogeneous_tuple.attribute"] == {
         "value": "(3, 2.0, 1, 4)",
@@ -438,11 +438,11 @@ def test_log_array_attributes(sentry_init, capture_envelopes):
 
     assert serialized_attributes["float_list.attribute"] == {
         "value": [3.0, 3.5, 4.2],
-        "type": "double[]",
+        "type": "array",
     }
     assert serialized_attributes["bool_tuple.attribute"] == {
         "value": [False, False, True],
-        "type": "boolean[]",
+        "type": "array",
     }
     assert serialized_attributes["inhomogeneous_list.attribute"] == {
         "value": "[3.2, True, None]",