Skip to content

Commit

Permalink
ref: Use explicit MYPY constant for readability
Browse files Browse the repository at this point in the history
  • Loading branch information
untitaker committed Jun 23, 2019
1 parent cd2206f commit 223e7a9
Showing 33 changed files with 68 additions and 34 deletions.
3 changes: 2 additions & 1 deletion sentry_sdk/_compat.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import sys

if False:
MYPY = False
if MYPY:
from typing import Optional
from typing import Tuple
from typing import Any
3 changes: 2 additions & 1 deletion sentry_sdk/api.py
Original file line number Diff line number Diff line change
@@ -5,7 +5,8 @@
from sentry_sdk.scope import Scope


if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Optional
from typing import overload
3 changes: 2 additions & 1 deletion sentry_sdk/client.py
Original file line number Diff line number Diff line change
@@ -17,7 +17,8 @@
from sentry_sdk.integrations import setup_integrations
from sentry_sdk.utils import ContextVar

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Callable
from typing import Dict
3 changes: 2 additions & 1 deletion sentry_sdk/consts.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import socket

if False:
MYPY = False
if MYPY:
from mypy_extensions import TypedDict
from typing import Optional
from typing import Callable
6 changes: 4 additions & 2 deletions sentry_sdk/hub.py
Original file line number Diff line number Diff line change
@@ -16,7 +16,8 @@
)


if False:
MYPY = False
if MYPY:
from contextlib import ContextManager
from sys import _OptExcInfo

@@ -174,7 +175,8 @@ class Hub(with_metaclass(HubMeta)): # type: ignore
_stack = None # type: List[Tuple[Optional[Client], Scope]]

# Mypy doesn't pick up on the metaclass.
if False:
MYPY = False
if MYPY:
current = None # type: Hub
main = None # type: Hub

3 changes: 2 additions & 1 deletion sentry_sdk/integrations/__init__.py
Original file line number Diff line number Diff line change
@@ -6,7 +6,8 @@
from sentry_sdk._compat import iteritems
from sentry_sdk.utils import logger

if False:
MYPY = False
if MYPY:
from typing import Iterator
from typing import Dict
from typing import List
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/_wsgi_common.py
Original file line number Diff line number Diff line change
@@ -4,7 +4,8 @@
from sentry_sdk.utils import AnnotatedValue
from sentry_sdk._compat import text_type, iteritems

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Dict
from typing import Optional
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/aiohttp.py
Original file line number Diff line number Diff line change
@@ -15,7 +15,8 @@
import asyncio
from aiohttp.web import Application, HTTPException # type: ignore

if False:
MYPY = False
if MYPY:
from aiohttp.web_request import Request # type: ignore
from typing import Any
from typing import Dict
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/argv.py
Original file line number Diff line number Diff line change
@@ -6,7 +6,8 @@
from sentry_sdk.integrations import Integration
from sentry_sdk.scope import add_global_event_processor

if False:
MYPY = False
if MYPY:
from typing import Optional

from sentry_sdk.utils import Event, Hint
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/atexit.py
Original file line number Diff line number Diff line change
@@ -8,7 +8,8 @@
from sentry_sdk.utils import logger
from sentry_sdk.integrations import Integration

if False:
MYPY = False
if MYPY:

from typing import Any
from typing import Optional
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/aws_lambda.py
Original file line number Diff line number Diff line change
@@ -11,7 +11,8 @@
from sentry_sdk.integrations import Integration
from sentry_sdk.integrations._wsgi_common import _filter_headers

if False:
MYPY = False
if MYPY:
from typing import Any


3 changes: 2 additions & 1 deletion sentry_sdk/integrations/bottle.py
Original file line number Diff line number Diff line change
@@ -10,7 +10,8 @@
from sentry_sdk.integrations.wsgi import SentryWsgiMiddleware
from sentry_sdk.integrations._wsgi_common import RequestExtractor

if False:
MYPY = False
if MYPY:

from sentry_sdk.integrations.wsgi import _ScopedResponse
from typing import Any
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/dedupe.py
Original file line number Diff line number Diff line change
@@ -3,7 +3,8 @@
from sentry_sdk.integrations import Integration
from sentry_sdk.scope import add_global_event_processor

if False:
MYPY = False
if MYPY:
from typing import Optional

from sentry_sdk.utils import Event, Hint
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/django/__init__.py
Original file line number Diff line number Diff line change
@@ -8,7 +8,8 @@
from django import VERSION as DJANGO_VERSION # type: ignore
from django.core import signals # type: ignore

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Callable
from typing import Dict
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/django/templates.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from django.template import TemplateSyntaxError # type: ignore

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Dict
from typing import Optional
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/django/transactions.py
Original file line number Diff line number Diff line change
@@ -7,7 +7,8 @@

import re

if False:
MYPY = False
if MYPY:
from django.urls.resolvers import URLResolver # type: ignore
from typing import Dict
from typing import List
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/excepthook.py
Original file line number Diff line number Diff line change
@@ -4,7 +4,8 @@
from sentry_sdk.utils import capture_internal_exceptions, event_from_exception
from sentry_sdk.integrations import Integration

if False:
MYPY = False
if MYPY:
from typing import Callable
from typing import Any

3 changes: 2 additions & 1 deletion sentry_sdk/integrations/falcon.py
Original file line number Diff line number Diff line change
@@ -8,7 +8,8 @@
from sentry_sdk.integrations.wsgi import SentryWsgiMiddleware
from sentry_sdk.utils import capture_internal_exceptions, event_from_exception

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Callable
from typing import Dict
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/flask.py
Original file line number Diff line number Diff line change
@@ -8,7 +8,8 @@
from sentry_sdk.integrations.wsgi import SentryWsgiMiddleware
from sentry_sdk.integrations._wsgi_common import RequestExtractor

if False:
MYPY = False
if MYPY:

from sentry_sdk.integrations.wsgi import _ScopedResponse
from typing import Any
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/gnu_backtrace.py
Original file line number Diff line number Diff line change
@@ -5,7 +5,8 @@
from sentry_sdk.scope import add_global_event_processor
from sentry_sdk.utils import capture_internal_exceptions

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Dict

3 changes: 2 additions & 1 deletion sentry_sdk/integrations/logging.py
Original file line number Diff line number Diff line change
@@ -13,7 +13,8 @@
from sentry_sdk.integrations import Integration
from sentry_sdk._compat import iteritems

if False:
MYPY = False
if MYPY:
from logging import LogRecord
from typing import Any
from typing import Dict
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/modules.py
Original file line number Diff line number Diff line change
@@ -4,7 +4,8 @@
from sentry_sdk.integrations import Integration
from sentry_sdk.scope import add_global_event_processor

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Dict
from typing import Tuple
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/pyramid.py
Original file line number Diff line number Diff line change
@@ -15,7 +15,8 @@
from sentry_sdk.integrations._wsgi_common import RequestExtractor
from sentry_sdk.integrations.wsgi import SentryWsgiMiddleware

if False:
MYPY = False
if MYPY:
from pyramid.response import Response # type: ignore
from typing import Any
from sentry_sdk.integrations.wsgi import _ScopedResponse
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/rq.py
Original file line number Diff line number Diff line change
@@ -9,7 +9,8 @@
from rq.timeouts import JobTimeoutException # type: ignore
from rq.worker import Worker # type: ignore

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Dict
from typing import Callable
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/sanic.py
Original file line number Diff line number Diff line change
@@ -18,7 +18,8 @@
from sanic.router import Router # type: ignore
from sanic.handlers import ErrorHandler # type: ignore

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Callable
from typing import Optional
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/threading.py
Original file line number Diff line number Diff line change
@@ -9,7 +9,8 @@
from sentry_sdk.utils import event_from_exception
from sentry_sdk.integrations import Integration

if False:
MYPY = False
if MYPY:
from typing import Any


3 changes: 2 additions & 1 deletion sentry_sdk/integrations/tornado.py
Original file line number Diff line number Diff line change
@@ -20,7 +20,8 @@
from tornado.web import RequestHandler, HTTPError # type: ignore
from tornado.gen import coroutine # type: ignore

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import List
from typing import Optional
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/wsgi.py
Original file line number Diff line number Diff line change
@@ -6,7 +6,8 @@
from sentry_sdk.tracing import SpanContext
from sentry_sdk.integrations._wsgi_common import _filter_headers

if False:
MYPY = False
if MYPY:
from typing import Callable
from typing import Dict
from typing import List
3 changes: 2 additions & 1 deletion sentry_sdk/scope.py
Original file line number Diff line number Diff line change
@@ -5,7 +5,8 @@

from sentry_sdk.utils import logger, capture_internal_exceptions

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Dict
from typing import Optional
3 changes: 2 additions & 1 deletion sentry_sdk/serializer.py
Original file line number Diff line number Diff line change
@@ -10,7 +10,8 @@

from sentry_sdk._compat import text_type, PY2, string_types, number_types, iteritems

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Dict
from typing import List
3 changes: 2 additions & 1 deletion sentry_sdk/transport.py
Original file line number Diff line number Diff line change
@@ -12,7 +12,8 @@
from sentry_sdk.utils import Dsn, logger, capture_internal_exceptions
from sentry_sdk.worker import BackgroundWorker

if False:
MYPY = False
if MYPY:
from sentry_sdk.consts import ClientOptions
from typing import Type
from typing import Any
3 changes: 2 additions & 1 deletion sentry_sdk/utils.py
Original file line number Diff line number Diff line change
@@ -8,7 +8,8 @@

from sentry_sdk._compat import urlparse, text_type, implements_str, int_types, PY2

if False:
MYPY = False
if MYPY:
from typing import Any
from typing import Callable
from typing import Dict
3 changes: 2 additions & 1 deletion sentry_sdk/worker.py
Original file line number Diff line number Diff line change
@@ -5,7 +5,8 @@
from sentry_sdk._compat import queue, check_thread_support
from sentry_sdk.utils import logger

if False:
MYPY = False
if MYPY:
from queue import Queue
from typing import Any
from typing import Optional

0 comments on commit 223e7a9

Please sign in to comment.