fix: marking transaction as failed (#66)

vaind · web-flow · commit c85b27c085f6 · 2024-10-23T16:32:33.000+02:00
diff --git a/samples/locate-city.ps1 b/samples/locate-city.ps1
@@ -54,7 +54,7 @@ try
         }
     }
     $span.Finish()
-
+    $transaction.Finish()
     if ($FoundOne)
     {
         exit 0 # success
@@ -64,11 +64,9 @@ try
 }
 catch
 {
+    # Mark the transaction as finished (note: this needs to be done prior to calling Out-Sentry)
+    $transaction.Finish($_.Exception)
+
     $_ | Out-Sentry
     "⚠️ Error on line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])"
 }
-finally
-{
-    # Mark the transaction as finished and send it to Sentry
-    $transaction.Finish()
-}

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ try`
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`	`$span.Finish()`
`57`		`-`
	`57`	`+ $transaction.Finish()`
`58`	`58`	`if ($FoundOne)`
`59`	`59`	`{`
`60`	`60`	`exit 0 # success`
`@@ -64,11 +64,9 @@ try`
`64`	`64`	`}`
`65`	`65`	`catch`
`66`	`66`	`{`
	`67`	`+ # Mark the transaction as finished (note: this needs to be done prior to calling Out-Sentry)`
	`68`	`+ $transaction.Finish($_.Exception)`
	`69`	`+`
`67`	`70`	`$_ \| Out-Sentry`
`68`	`71`	`"⚠️ Error on line $($_.InvocationInfo.ScriptLineNumber): $($Error[0])"`
`69`	`72`	`}`
`70`		`-finally`
`71`		`-{`
`72`		`- # Mark the transaction as finished and send it to Sentry`
`73`		`- $transaction.Finish()`
`74`		`-}`