-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user feedback capability to the Native SDK #966
Add user feedback capability to the Native SDK #966
Conversation
…tive into feat/user_feedback
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
- Coverage 82.65% 82.63% -0.03%
==========================================
Files 53 53
Lines 7376 7444 +68
Branches 1186 1198 +12
==========================================
+ Hits 6097 6151 +54
- Misses 1171 1182 +11
- Partials 108 111 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks a lot! One minor change.
I think this should also find its way into the docs.
@supervacuus Thanks for the prompt feedback! I've updated the integration tests as you suggested and opened a corresponding PR for the docs. |
This PR introduces a new API allowing to create/capture user feedback for specific events (similar functionality is offered by native Android and Apple SDKs).
It will be later exposed to the Unreal Engine plugin where user feedback capabilities have been requested recently. While the existing user feedback endpoint provides an alternative it requires deviating from our current approach of utilizing the native SDKs for client app communication with Sentry there.
Related to #885