Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user feedback capability to the Native SDK #966

Merged
merged 20 commits into from
Mar 21, 2024

Conversation

tustanivsky
Copy link
Collaborator

This PR introduces a new API allowing to create/capture user feedback for specific events (similar functionality is offered by native Android and Apple SDKs).

It will be later exposed to the Unreal Engine plugin where user feedback capabilities have been requested recently. While the existing user feedback endpoint provides an alternative it requires deviating from our current approach of utilizing the native SDKs for client app communication with Sentry there.

Related to #885

@kahest kahest requested a review from supervacuus March 19, 2024 13:49
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 80.88235% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 82.63%. Comparing base (e812e7c) to head (1b6c03c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   82.65%   82.63%   -0.03%     
==========================================
  Files          53       53              
  Lines        7376     7444      +68     
  Branches     1186     1198      +12     
==========================================
+ Hits         6097     6151      +54     
- Misses       1171     1182      +11     
- Partials      108      111       +3     

Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks a lot! One minor change.

I think this should also find its way into the docs.

examples/example.c Outdated Show resolved Hide resolved
@tustanivsky
Copy link
Collaborator Author

@supervacuus Thanks for the prompt feedback! I've updated the integration tests as you suggested and opened a corresponding PR for the docs.

@supervacuus supervacuus merged commit fda2a37 into getsentry:master Mar 21, 2024
19 checks passed
@tustanivsky tustanivsky deleted the feat/user_feedback branch March 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide user-feedback capability to the Native SDK
2 participants