build: remove obsolete CRASHPAD_WER_ENABLED #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we initially introduced the build flag because of a potentially missing struct member if an older target version than 19041 was selected in a build: getsentry/crashpad#70 But upstream fixed that with a local compatibility struct a while ago: https://chromium.googlesource.com/crashpad/crashpad/+/ca928c8d6b651b7123f1a5cad36dba08ca2416bc That means we can get rid of the build-flag entirely, because this will build on all supported platforms and add a runtime version check for `build == 19041`, so that we don't even register the module (including not polluting the registry) on WER versions that don't support fast-fail crashes .
* missing new line at EOF (added clang-format rule available with 16) * differences between CI clang-format (15) and local ones (17) led to disagreement with spacing around binary operator in macros.
…ion to not complain about unknown keys.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
==========================================
- Coverage 86.53% 82.64% -3.89%
==========================================
Files 40 53 +13
Lines 3676 7376 +3700
Branches 0 1186 +1186
==========================================
+ Hits 3181 6096 +2915
- Misses 495 1171 +676
- Partials 0 109 +109 |
Swatinem
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we initially introduced the build flag because of a potentially missing struct member if an older target version than 19041 was selected in a build:
getsentry/crashpad#70
But upstream fixed that with a local compatibility struct a while ago:
https://chromium.googlesource.com/crashpad/crashpad/+/ca928c8d6b651b7123f1a5cad36dba08ca2416bc
That means we can get rid of the build-flag entirely, because this will build on all supported platforms and add a runtime version check for
build == 19041, so that we don't even register the module (including not polluting the registry) on WER versions that don't support fast-fail crashes .